Improve GpioControllerValueChanged (#9)

josesimoes · web-flow · commit 871666ae1221 · 2020-10-22T14:54:39.000+01:00
diff --git a/System.Device.Gpio/GpioController.cs b/System.Device.Gpio/GpioController.cs
@@ -269,16 +269,16 @@ private void GpioControllerValueChanged(
             // sanity check
             if(gpioPin != null)
             {
-                if (((gpioPin.GpioEvents & PinEventTypes.Falling) == PinEventTypes.Falling)
-                    && ((e.ChangeType & PinEventTypes.Falling) == PinEventTypes.Falling))
+                if (gpioPin.GpioEvents.HasFlag(PinEventTypes.Falling)
+                    && e.ChangeType.HasFlag(PinEventTypes.Falling))
                 {
                     gpioPin.GpioPinChange.Invoke(
                         this,
                         new PinValueChangedEventArgs(PinEventTypes.Falling, gpioPin.PinNumber));
                 }
 
-                if (((gpioPin.GpioEvents & PinEventTypes.Rising) == PinEventTypes.Rising)
-                    && ((e.ChangeType & PinEventTypes.Rising) == PinEventTypes.Rising))
+                if (gpioPin.GpioEvents.HasFlag(PinEventTypes.Rising)
+                    && e.ChangeType.HasFlag(PinEventTypes.Rising))
                 {
                     gpioPin.GpioPinChange.Invoke(
                         this,

Original file line number	Diff line number	Diff line change
`@@ -269,16 +269,16 @@ private void GpioControllerValueChanged(`
`269`	`269`	`// sanity check`
`270`	`270`	`if(gpioPin != null)`
`271`	`271`	`{`
`272`		`- if (((gpioPin.GpioEvents & PinEventTypes.Falling) == PinEventTypes.Falling)`
`273`		`- && ((e.ChangeType & PinEventTypes.Falling) == PinEventTypes.Falling))`
	`272`	`+ if (gpioPin.GpioEvents.HasFlag(PinEventTypes.Falling)`
	`273`	`+ && e.ChangeType.HasFlag(PinEventTypes.Falling))`
`274`	`274`	`{`
`275`	`275`	`gpioPin.GpioPinChange.Invoke(`
`276`	`276`	`this,`
`277`	`277`	`new PinValueChangedEventArgs(PinEventTypes.Falling, gpioPin.PinNumber));`
`278`	`278`	`}`
`279`	`279`
`280`		`- if (((gpioPin.GpioEvents & PinEventTypes.Rising) == PinEventTypes.Rising)`
`281`		`- && ((e.ChangeType & PinEventTypes.Rising) == PinEventTypes.Rising))`
	`280`	`+ if (gpioPin.GpioEvents.HasFlag(PinEventTypes.Rising)`
	`281`	`+ && e.ChangeType.HasFlag(PinEventTypes.Rising))`
`282`	`282`	`{`
`283`	`283`	`gpioPin.GpioPinChange.Invoke(`
`284`	`284`	`this,`