Fix SerialPort Dispose warning (#99)

***NO_CI***

Author: networkfusion

System.IO.Ports/SerialPort.cs

@@ -783,7 +783,7 @@ internal static SerialPort FindDevice(int index)
         /// <exception cref="IOException">The port is in an invalid state. -or- An attempt to set the state of the underlying
         /// port failed. For example, the parameters passed from this <see cref="SerialPort"/>
         /// object were invalid.</exception>
-        protected void Dispose(bool disposing)
+        internal void Dispose(bool disposing)
         {
             if (!_disposed)
             {

System.IO.Ports/System.IO.Ports.nfproj

@@ -80,11 +80,11 @@
       <ProjectConfigurationsDeclaredAsItems />
     </ProjectCapabilities>
   </ProjectExtensions>
-  <Import Project="..\packages\Nerdbank.GitVersioning.3.4.194\build\Nerdbank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.3.4.194\build\Nerdbank.GitVersioning.targets')" />
+  <Import Project="..\packages\Nerdbank.GitVersioning.3.5.107\build\Nerdbank.GitVersioning.targets" Condition="Exists('..\packages\Nerdbank.GitVersioning.3.5.107\build\Nerdbank.GitVersioning.targets')" />
   <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
     <PropertyGroup>
       <ErrorText>This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105.The missing file is {0}.</ErrorText>
     </PropertyGroup>
-    <Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.3.4.194\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.3.4.194\build\Nerdbank.GitVersioning.targets'))" />
+    <Error Condition="!Exists('..\packages\Nerdbank.GitVersioning.3.5.107\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Nerdbank.GitVersioning.3.5.107\build\Nerdbank.GitVersioning.targets'))" />
   </Target>
 </Project>

System.IO.Ports/packages.config

@@ -4,5 +4,5 @@
   <package id="nanoFramework.Runtime.Events" version="1.10.0" targetFramework="netnanoframework10" />
   <package id="nanoFramework.System.IO.Streams" version="1.1.9" targetFramework="netnanoframework10" />
   <package id="nanoFramework.System.Text" version="1.2.3" targetFramework="netnanoframework10" />
-  <package id="Nerdbank.GitVersioning" version="3.4.194" developmentDependency="true" targetFramework="netnanoframework10" />
+  <package id="Nerdbank.GitVersioning" version="3.5.107" targetFramework="netnanoframework10" developmentDependency="true" />
 </packages>

Tests/UnitTestsSerialPort/SerialTests.cs

@@ -23,9 +23,10 @@ public class SerialTests
         [Setup]
         public void SetupComPorts()
         {
+            OutputHelper.WriteLine("Setting up tests for an ESP32...");
             try
             {
-                Debug.WriteLine("Please adjust for your own usage. If you need another hardware, please add the proper nuget and adjust as well");
+                OutputHelper.WriteLine("Please adjust for your own usage. If you need another hardware, please add the proper nuget and adjust as well");
                 Configuration.SetPinFunction(32, DeviceFunction.COM2_RX);
                 Configuration.SetPinFunction(33, DeviceFunction.COM2_TX);
                 Configuration.SetPinFunction(12, DeviceFunction.COM2_RTS);
@@ -36,22 +37,23 @@ public void SetupComPorts()
                 Configuration.SetPinFunction(27, DeviceFunction.COM3_RTS);
                 Configuration.SetPinFunction(14, DeviceFunction.COM3_CTS);
 
-                Debug.WriteLine("You will need to connect:");
-                Debug.WriteLine("  COM2 RX  <-> COM3 TX");
-                Debug.WriteLine("  COM2 TX  <-> COM3 RX");
-                Debug.WriteLine("  COM2 RTS <-> COM3 CTS");
-                Debug.WriteLine("  COM2 CTS <-> COM3 RTS");
+                OutputHelper.WriteLine("You will need to connect:");
+                OutputHelper.WriteLine("  COM2 RX  <-> COM3 TX");
+                OutputHelper.WriteLine("  COM2 TX  <-> COM3 RX");
+                OutputHelper.WriteLine("  COM2 RTS <-> COM3 CTS");
+                OutputHelper.WriteLine("  COM2 CTS <-> COM3 RTS");
                 _serOne = new SerialPort("COM2");
                 _serTwo = new SerialPort("COM3");
-                Debug.WriteLine("Devices created, trying to open them");
+                OutputHelper.WriteLine("SerialPorts created, trying to open them");
                 _serOne.Open();
-                Debug.WriteLine("Serial One COM2 opened");
+                OutputHelper.WriteLine("SerialPort One COM2 opened.");
                 _serTwo.Open();
-                Debug.WriteLine("Devices opened, will close them");
-                // Wait a bit just to make sure and close them again
+                OutputHelper.WriteLine("SerialPort Two COM3 opened.");
+                OutputHelper.WriteLine("All SerialPorts opened, will close them");
+                // Wait a bit just to make sure and close them all
                 Thread.Sleep(100);
-                _serOne.Close();
-                _serTwo.Close();
+                EnsurePortsClosed();
+                OutputHelper.WriteLine("SerialPorts Closed.");
             }
             catch
             {
@@ -63,10 +65,10 @@ public void SetupComPorts()
         public void GetPortNamesTest()
         {
             var ports = SerialPort.GetPortNames();
-            Debug.WriteLine("Available ports:");
+            OutputHelper.WriteLine("Available SerialPorts:");
             foreach (string port in ports)
             {
-                Debug.WriteLine($"  {port}");
+                OutputHelper.WriteLine($"  {port}");
             }
         }