Improvements and fixes in SerialPort (#16)

Author: josesimoes

System.IO.Ports/Properties/AssemblyInfo.cs

@@ -12,7 +12,7 @@
 
 ////////////////////////////////////////////////////////////////
 // update this whenever the native assembly signature changes //
-[assembly: AssemblyNativeVersion("100.1.1.2")]
+[assembly: AssemblyNativeVersion("100.1.1.3")]
 ////////////////////////////////////////////////////////////////
 
 // Setting ComVisible to false makes the types in this assembly not visible 

System.IO.Ports/SerialData.cs

@@ -20,4 +20,4 @@ public enum SerialData
         /// </summary>
         WatchChar = 2
     }
-}
+}

System.IO.Ports/SerialDataReceivedEventArgs.cs

@@ -22,4 +22,4 @@ internal SerialDataReceivedEventArgs(SerialData eventCode)
         /// </summary>
         public SerialData EventType { get => _data; }
     }
-}
+}

System.IO.Ports/SerialDataReceivedEventHandler.cs

@@ -11,5 +11,7 @@ namespace System.IO.Ports
     /// </summary>
     /// <param name="sender">The sender of the event, which is the <see cref="SerialPort"/> object.</param>
     /// <param name="e">A <see cref="SerialDataReceivedEventArgs"/> object that contains the event data.</param>
-    public delegate void SerialDataReceivedEventHandler(object sender, SerialDataReceivedEventArgs e);
+    public delegate void SerialDataReceivedEventHandler(
+        object sender,
+        SerialDataReceivedEventArgs e);
 }

System.IO.Ports/SerialDeviceController.cs

@@ -10,16 +10,13 @@ namespace System.IO.Ports
     /// <summary>
     /// This class is used to keep tabs on what serial ports are open.
     /// </summary>
-    internal sealed class SerialDeviceController
+    internal static class SerialDeviceController
     {
         // this is used as the lock object 
         // a lock is required because multiple threads can access the SerialDevice controller
+        [System.Diagnostics.DebuggerBrowsable(Diagnostics.DebuggerBrowsableState.Never)]
         private static object _syncLock;
 
-        // we can have only one instance of the SerialDeviceController
-        // need to do a lazy initialization of this field to make sure it exists when called elsewhere.
-        private static SerialDeviceController s_instance;
-
         // backing field for DeviceCollection
         private static ArrayList s_deviceCollection;
 
@@ -57,30 +54,5 @@ internal static ArrayList DeviceCollection
                 s_deviceCollection = value;
             }
         }
-
-        /// <summary>
-        /// Gets the default serial device controller for the system.
-        /// </summary>
-        /// <returns>The default GPIO controller for the system, or null if the system has no GPIO controller.</returns>
-        internal static SerialDeviceController GetDefault()
-        {
-            if (s_instance == null)
-            {
-                if (_syncLock == null)
-                {
-                    _syncLock = new object();
-                }
-
-                lock (_syncLock)
-                {
-                    if (s_instance == null)
-                    {
-                        s_instance = new SerialDeviceController();
-                    }
-                }
-            }
-
-            return s_instance;
-        }
     }
 }