WirelessAPConfiguration.MaxConnections is now validated (#307)

Author: CoryCharlton

nanoFramework.System.Net/NetworkInformation/WirelessAPConfiguration.cs

@@ -121,7 +121,12 @@ public WirelessAPConfiguration(uint id)
         /// <remarks>
         /// Checks the length of SSID is 32 or less.
         /// Password length is between 8 and 64 if not an open Authentication.
+        /// Max connections has to be greater than zero.
         /// </remarks>
+        /// <exception cref="ArgumentOutOfRangeException">If <see cref="MaxConnections"/> is less than one.</exception>
+        /// <exception cref="ArgumentOutOfRangeException">If <see cref="Password"/> is less than 8 character or more than 64 characters and not open <see cref="Authentication"/>.</exception>
+        /// <exception cref="ArgumentOutOfRangeException">If <see cref="Ssid"/> is longer than <see cref="MaxApSsidLength"/><./exception>
+        /// <exception cref="ArgumentNullException">If <see cref="Ssid"/> is <see langword="null"/>.</exception>
         public void SaveConfiguration()
         {
             // Before we update validate whether settings conform to right characteristics.
@@ -130,6 +135,13 @@ public void SaveConfiguration()
             UpdateConfiguration();
         }
 
+        /// <summary>
+        /// Validates the wireless Soft AP configuration information 
+        /// </summary>
+        /// <exception cref="ArgumentOutOfRangeException">If <see cref="MaxConnections"/> is less than one.</exception>
+        /// <exception cref="ArgumentOutOfRangeException">If <see cref="Password"/> is less than 8 character or more than 64 characters and not open <see cref="Authentication"/>.</exception>
+        /// <exception cref="ArgumentOutOfRangeException">If <see cref="Ssid"/> is longer than <see cref="MaxApSsidLength"/><./exception>
+        /// <exception cref="ArgumentNullException">If <see cref="Ssid"/> is <see langword="null"/>.</exception>
         private void ValidateConfiguration()
         {
             // SSID can't be null
@@ -148,6 +160,14 @@ private void ValidateConfiguration()
 #pragma warning restore S3928 // Parameter names used into ArgumentException constructors should match an existing one 
             }
 
+            // At least one MaxConnection is required
+            if (_apMaxConnections < 1)
+            {
+#pragma warning disable S3928 // OK to not include a meaningful message
+                throw new ArgumentOutOfRangeException();
+#pragma warning restore S3928 // Parameter names used into ArgumentException constructors should match an existing one 
+            }
+
             // If not using an open Auth then check password length
             if ( (Authentication != AuthenticationType.Open && Authentication != AuthenticationType.None)  &&
                  ( (_apPassword.Length <  MinApPasswordLength) || (_apPassword.Length >= MaxApPasswordLength) ) )