Fix processing of value parameters

josesimoes · josesimoes · commit 8b33664afb19 · 2019-12-11T13:06:43.000Z
***NO_CI***

Signed-off-by: José Simões &lt;jose.simoes@eclo.solutions&gt;
diff --git a/source/MetadataProcessor.Core/Utility/NativeMethodsCrc.cs b/source/MetadataProcessor.Core/Utility/NativeMethodsCrc.cs
@@ -103,11 +103,10 @@ private static string GetParameterType(
                 typeName += nanoCLR_DataType.DATATYPE_BYREF + "_" + GetnanoClrTypeName(parameterType.GetElementType());
                 continueProcessing = false;
             }
-            else if(!parameterType.IsPrimitive &&
-                parameterType.IsValueType)
+            else if(!parameterType.IsPrimitive)
             {
                 // TBD
-                continueProcessing = false;
+                continueProcessing = true;
             }
 
             if (continueProcessing)
@@ -117,7 +116,7 @@ private static string GetParameterType(
 
             // clear 'DATATYPE_' prefixes 
             // and make it upper case
-            return typeName.Replace("DATATYPE_", "").ToUpper();
+            return typeName.Replace("DATATYPE_", "");
         }
 
         internal static string GetnanoClrTypeName(TypeReference parameterType)

Original file line number	Diff line number	Diff line change
`@@ -103,11 +103,10 @@ private static string GetParameterType(`
`103`	`103`	`typeName += nanoCLR_DataType.DATATYPE_BYREF + "_" + GetnanoClrTypeName(parameterType.GetElementType());`
`104`	`104`	`continueProcessing = false;`
`105`	`105`	`}`
`106`		`- else if(!parameterType.IsPrimitive &&`
`107`		`- parameterType.IsValueType)`
	`106`	`+ else if(!parameterType.IsPrimitive)`
`108`	`107`	`{`
`109`	`108`	`// TBD`
`110`		`- continueProcessing = false;`
	`109`	`+ continueProcessing = true;`
`111`	`110`	`}`
`112`	`111`
`113`	`112`	`if (continueProcessing)`
`@@ -117,7 +116,7 @@ private static string GetParameterType(`
`117`	`116`
`118`	`117`	`// clear 'DATATYPE_' prefixes`
`119`	`118`	`// and make it upper case`
`120`		`- return typeName.Replace("DATATYPE_", "").ToUpper();`
	`119`	`+ return typeName.Replace("DATATYPE_", "");`
`121`	`120`	`}`
`122`	`121`
`123`	`122`	`internal static string GetnanoClrTypeName(TypeReference parameterType)`