Fix help message showing despite operation executed (#68)

***NO_CI***

Author: josesimoes

nanoFirmwareFlasher/Program.cs

@@ -121,6 +121,8 @@ private static Task HandleErrorsAsync(IEnumerable<Error> errors)
 
         static async Task RunOptionsAndReturnExitCodeAsync(Options o)
         {
+            bool operationPerformed = false;
+
             #region parse verbosity option
 
             switch (o.Verbosity)
@@ -333,11 +335,14 @@ static async Task RunOptionsAndReturnExitCodeAsync(Options o)
                     {
                         // backup path specified, backup deployment
                         _exitCode = Esp32Operations.BackupFlash(espTool, esp32Device, o.BackupPath, o.BackupFile, _verbosityLevel);
+                        
                         if (_exitCode != ExitCodes.OK)
                         {
                             // done here
                             return;
                         }
+
+                        operationPerformed = true;
                     }
                     catch (ReadEsp32FlashException ex)
                     {
@@ -470,22 +475,16 @@ static async Task RunOptionsAndReturnExitCodeAsync(Options o)
                 {
                     _exitCode = Stm32Operations.InstallDfuDrivers(_verbosityLevel);
 
-                    if (_exitCode != ExitCodes.OK)
-                    {
-                        // done here
-                        return;
-                    }
+                    // done here
+                    return;
                 }
 
                 if (o.InstallJtagDrivers)
                 {
                     _exitCode = Stm32Operations.InstallJtagDrivers(_verbosityLevel);
 
-                    if (_exitCode != ExitCodes.OK)
-                    {
-                        // done here
-                        return;
-                    }
+                    // done here
+                    return;
                 }
 
                 if (o.ListDevicesInDfuMode)
@@ -712,6 +711,8 @@ static async Task RunOptionsAndReturnExitCodeAsync(Options o)
                             updateInterface,
                             _verbosityLevel);
 
+                        operationPerformed = true;
+
                         if (_exitCode != ExitCodes.OK)
                         {
                             // done here
@@ -767,6 +768,8 @@ static async Task RunOptionsAndReturnExitCodeAsync(Options o)
                                         updateInterface,
                                         _verbosityLevel);
 
+                        operationPerformed = true;
+
                         if (_exitCode != ExitCodes.OK)
                         {
                             // done here
@@ -814,14 +817,10 @@ static async Task RunOptionsAndReturnExitCodeAsync(Options o)
             {
                 if (o.TIInstallXdsDrivers)
                 {
-
                     _exitCode = CC13x26x2Operations.InstallXds110Drivers(_verbosityLevel);
 
-                    if (_exitCode != ExitCodes.OK)
-                    {
-                        // done here
-                        return;
-                    }
+                    // done here
+                    return;
                 }
 
                 if (!string.IsNullOrEmpty(o.TargetName))
@@ -849,6 +848,8 @@ static async Task RunOptionsAndReturnExitCodeAsync(Options o)
                             appFlashAddress,
                             _verbosityLevel);
 
+                        operationPerformed = true;
+
                         if (_exitCode != ExitCodes.OK)
                         {
                             // done here
@@ -884,6 +885,8 @@ static async Task RunOptionsAndReturnExitCodeAsync(Options o)
                                         appFlashAddress,
                                         _verbosityLevel);
 
+                        operationPerformed = true;
+
                         if (_exitCode != ExitCodes.OK)
                         {
                             // done here
@@ -906,23 +909,26 @@ static async Task RunOptionsAndReturnExitCodeAsync(Options o)
 
             #endregion
 
-            // done nothing...
-            // because of short-comings in CommandLine parsing 
-            // need to customize the output to provide a consistent output
-            var parser = new Parser(config => config.HelpWriter = null);
-            var result = parser.ParseArguments<Options>(new[] { "", "" });
-
-            var helpText = new HelpText(
-                new HeadingInfo(_headerInfo),
-                _copyrightInfo)
-                    .AddPreOptionsLine("")
-                    .AddPreOptionsLine("No operation was performed with the options supplied.")
-                    .AddPreOptionsLine("")
-                    .AddPreOptionsLine(HelpText.RenderUsageText(result))
-                    .AddPreOptionsLine("")
-                    .AddOptions(result);
-
-            Console.WriteLine(helpText.ToString());
+            // done nothing... or maybe not...
+            if (!operationPerformed)
+            {
+                // because of short-comings in CommandLine parsing 
+                // need to customize the output to provide a consistent output
+                var parser = new Parser(config => config.HelpWriter = null);
+                var result = parser.ParseArguments<Options>(new[] { "", "" });
+
+                var helpText = new HelpText(
+                    new HeadingInfo(_headerInfo),
+                    _copyrightInfo)
+                        .AddPreOptionsLine("")
+                        .AddPreOptionsLine("No operation was performed with the options supplied.")
+                        .AddPreOptionsLine("")
+                        .AddPreOptionsLine(HelpText.RenderUsageText(result))
+                        .AddPreOptionsLine("")
+                        .AddOptions(result);
+
+                Console.WriteLine(helpText.ToString());
+            }
         }
 
         private static void OutputError(ExitCodes errorCode, bool outputMessage, string extraMessage = null)

nanoFirmwareFlasher/Stm32Operations.cs

@@ -210,7 +210,9 @@ internal static async System.Threading.Tasks.Task<ExitCodes> UpdateFirmwareAsync
                     programResult = jtagDevice.FlashBinFiles(new [] { applicationPath }, new [] { deploymentAddress });
                 }
 
-                if(updateFw)
+                if(
+                    updateFw 
+                    && programResult == ExitCodes.OK)
                 {
                     // reset MCU
                     jtagDevice.ResetMcu();