Fix output of device operations (#249)

Author: josesimoes

nanoFirmwareFlasher.Tool/NanoDeviceManager.cs

@@ -29,6 +29,9 @@ public NanoDeviceManager(Options options, VerbosityLevel verbosityLevel)
         /// <inheritdoc />
         public async Task<ExitCodes> ProcessAsync()
         {
+            bool failedToDoSomething = true;
+            ExitCodes exitCode = ExitCodes.OK;
+
             // COM port is mandatory for nano device operations
             if (string.IsNullOrEmpty(_options.SerialPort))
             {
@@ -46,7 +49,7 @@ public async Task<ExitCodes> ProcessAsync()
             }
             else if (_options.Update)
             {
-                var exitCode = await _nanoDeviceOperations.UpdateDeviceClrAsync(
+                exitCode = await _nanoDeviceOperations.UpdateDeviceClrAsync(
                     _options.SerialPort,
                     _options.FwVersion,
                     _options.ClrFile,
@@ -56,11 +59,14 @@ public async Task<ExitCodes> ProcessAsync()
                 {
                     return exitCode;
                 }
+
+                // flag operation as done
+                failedToDoSomething = false;
             }
 
             if (_options.Deploy)
             {
-                var exitCode = _nanoDeviceOperations.DeployApplication(
+                exitCode = _nanoDeviceOperations.DeployApplication(
                     _options.SerialPort,
                     _options.DeploymentImage,
                     _verbosityLevel);
@@ -69,9 +75,17 @@ public async Task<ExitCodes> ProcessAsync()
                 {
                     return exitCode;
                 }
+
+                // flag operation as done
+                failedToDoSomething = false;
+            }
+
+            if (failedToDoSomething)
+            {
+                throw new NoOperationPerformedException();
             }
 
-            throw new NoOperationPerformedException();
+            return exitCode;
         }
     }
 }

nanoFirmwareFlasher.Tool/Program.cs

@@ -364,30 +364,32 @@ static async Task RunOptionsAndReturnExitCodeAsync(Options o)
             {
                 var manager = new NanoDeviceManager(o, _verbosityLevel);
 
-                try
-                {
-                    _exitCode = await manager.ProcessAsync();
-                }
-                catch (CantConnectToNanoDeviceException ex)
-                {
-                    _exitCode = ExitCodes.E2001;
-                    _extraMessage = ex.Message;
-                }
-                catch (NoOperationPerformedException)
-                {
-                    DisplayNoOperationMessage();
-                }
-                catch (Exception ex)
-                {
-                    _exitCode = ExitCodes.E2002;
-                    _extraMessage = ex.Message;
-                }
-
                 // COM port is mandatory for nano device operations
                 if (string.IsNullOrEmpty(o.SerialPort))
                 {
                     _exitCode = ExitCodes.E6001;
                 }
+                else
+                {
+                    try
+                    {
+                        _exitCode = await manager.ProcessAsync();
+                    }
+                    catch (CantConnectToNanoDeviceException ex)
+                    {
+                        _exitCode = ExitCodes.E2001;
+                        _extraMessage = ex.Message;
+                    }
+                    catch (NoOperationPerformedException)
+                    {
+                        DisplayNoOperationMessage();
+                    }
+                    catch (Exception ex)
+                    {
+                        _exitCode = ExitCodes.E2002;
+                        _extraMessage = ex.Message;
+                    }
+                }
 
                 return;
             }