Improvements in target validation and search (#101)

Author: josesimoes

nanoFirmwareFlasher/CloudsmithPackageInfo.cs

@@ -19,5 +19,8 @@ internal class CloudsmithPackageInfo
 
         [JsonProperty("name")]
         public string TargetName { get; set; }
+
+        [JsonProperty("uploaded_at")]
+        public DateTime PackageDate { get; set; }
     }
 }

nanoFirmwareFlasher/FirmwarePackage.cs

@@ -78,7 +78,7 @@ public static List<CloudSmithPackageDetail> GetTargetList(
             VerbosityLevel verbosity)
         {
             string repoName = communityTargets ? _communityTargetsRepo : preview ? _refTargetsDevRepo : _refTargetsStableRepo;
-            string requestUri = $"{_cloudsmithPackages}/{repoName}/?tag={platform}";
+            string requestUri = $"{_cloudsmithPackages}/{repoName}/?&q=uploaded:>'2 months ago'&tag={platform}";
             List<CloudSmithPackageDetail> targetPackages = new();
 
             if (verbosity > VerbosityLevel.Normal)
@@ -203,7 +203,7 @@ protected async System.Threading.Tasks.Task<ExitCodes> DownloadAndExtractAsync()
                                    .ToList();
             }
 
-           
+
             if (!skipDownload)
             {
                 // try to perform request
@@ -220,6 +220,8 @@ protected async System.Threading.Tasks.Task<ExitCodes> DownloadAndExtractAsync()
                     string responseBody = await response.Content.ReadAsStringAsync();
 
                     bool targetNotFound = false;
+                    bool packageOutdated = false;
+                    List<CloudsmithPackageInfo> packageInfo = null;
 
                     // check for empty array 
                     if (responseBody == "[]")
@@ -229,7 +231,7 @@ protected async System.Threading.Tasks.Task<ExitCodes> DownloadAndExtractAsync()
                     else
                     {
                         // parse response
-                        List<CloudsmithPackageInfo> packageInfo = JsonConvert.DeserializeObject<List<CloudsmithPackageInfo>>(responseBody);
+                        packageInfo = JsonConvert.DeserializeObject<List<CloudsmithPackageInfo>>(responseBody);
 
                         // if no specific version was requested, use latest available
                         if (string.IsNullOrEmpty(_fwVersion))
@@ -242,9 +244,9 @@ protected async System.Threading.Tasks.Task<ExitCodes> DownloadAndExtractAsync()
                         {
                             //get the download Url from the Cloudsmith Package info
                             // addition check if the cloudsmith json return empty json
-                            if(packageInfo is null || packageInfo.Count == 0)
-                            {    
-                               return ExitCodes.E9005;
+                            if (packageInfo is null || packageInfo.Count == 0)
+                            {
+                                return ExitCodes.E9005;
                             }
                             else
                             {
@@ -253,13 +255,22 @@ protected async System.Threading.Tasks.Task<ExitCodes> DownloadAndExtractAsync()
                         }
 
                         // sanity check for target name matching requested
-                        if(packageInfo.ElementAt(0).TargetName != _targetName)
+                        if (packageInfo.ElementAt(0).TargetName != _targetName)
                         {
                             targetNotFound = true;
                         }
+                        else
+                        {
+                            // check package published date
+                            if (packageInfo.ElementAt(0).PackageDate < DateTime.UtcNow.AddMonths(-2))
+                            {
+                                // if older than 2 months warn user
+                                packageOutdated = true;
+                            }
+                        }
                     }
 
-                    if(targetNotFound)
+                    if (targetNotFound)
                     {
                         // can't find this target
 
@@ -290,6 +301,21 @@ protected async System.Threading.Tasks.Task<ExitCodes> DownloadAndExtractAsync()
                         Console.ForegroundColor = ConsoleColor.White;
                     }
 
+                    if (packageOutdated)
+                    {
+                        Console.ForegroundColor = ConsoleColor.DarkYellow;
+                        Console.WriteLine();
+
+                        Console.WriteLine("******************************* WARNING ******************************");
+                        Console.WriteLine($"** This firmware package was released at {packageInfo.ElementAt(0).PackageDate.ToShortDateString()}                 **");
+                        Console.WriteLine("** The target it's probably outdated.                               **");
+                        Console.WriteLine("** Please check the current target names here: https://git.io/JyfuI **");
+                        Console.WriteLine("**********************************************************************");
+
+                        Console.WriteLine();
+                        Console.ForegroundColor = ConsoleColor.White;
+                    }
+
                     // set exposed property
                     Version = _fwVersion;