Remove buffer fill in dfu upload (#32)

Author: josesimoes

source/nanoFirmwareFlasher/StDfu.cs

@@ -855,7 +855,7 @@ private static void EraseSector(
                         returnValue = STDFU_GetStatus(ref hDevice, ref dfuStatus);
                     }
 
-                    if (dfuStatus.bState != STDFU_NOERROR)
+                    if (returnValue != STDFU_NOERROR)
                     {
                         throw new DownloadException("STDFU_Dnload returned " + returnValue.ToString("X8"));
                     }
@@ -934,10 +934,10 @@ internal static void WriteBlock(
 
             returnValue = STDFU_Dnload(ref hDevice, data, (uint)data.Length, (ushort)(blockNumber + 2));
 
-            if (STDFU_GetStatus(ref hDevice, ref dfuStatus) != STATE_DFU_DOWNLOAD_BUSY)
+            STDFU_GetStatus(ref hDevice, ref dfuStatus);
+            if (dfuStatus.bState != STATE_DFU_DOWNLOAD_BUSY)
             {
                 throw new DownloadException("STDFU_Dnload returned " + returnValue.ToString("X8"));
-
             }
 
             while (dfuStatus.bState != STATE_DFU_IDLE)

source/nanoFirmwareFlasher/StmDfuDevice.cs

@@ -247,18 +247,6 @@ public void FlashDfuFile(string filePath)
                     // grab data for write and store it into a 2048 byte buffer
                     byte[] buffer = dfuElement.Data.Skip((int)(_maxWriteBlockSize * blockNumber)).Take(_maxWriteBlockSize).ToArray();
 
-                    if (buffer.Length < _maxWriteBlockSize)
-                    {
-                        var i = buffer.Length;
-                        Array.Resize(ref buffer, _maxWriteBlockSize);
-
-                        // Pad with 0xFF so our CRC matches the ST Bootloader and STLink's CRC
-                        for (; i < _maxWriteBlockSize; i++)
-                        {
-                            buffer[i] = 0xFF;
-                        }
-                    }
-
                     StDfu.WriteBlock(_hDevice, dfuElement.Address, buffer, blockNumber);
                 }
             }