Skip to content

Commit eb003fb

Browse files
authored
Fix S3 broken --masserase option (#274)
1 parent 18c31ba commit eb003fb

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

nanoFirmwareFlasher.Library/EspTool.cs

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -247,12 +247,17 @@ public Esp32DeviceInfo GetDeviceDetails(
247247
// these series doesn't have PSRAM
248248
psramIsAvailable = PSRamAvailability.No;
249249
}
250+
else if (_chipType == "esp32s3")
251+
{
252+
// For now assuming all S3 have PSRAM.
253+
// TODO: following https://github.com/espressif/esptool/issues/970
254+
// The download mode register is not cleared so a reset/run command does not work on the S3. We should retest this after depending on what will be the fix for that issue.
255+
psramIsAvailable = PSRamAvailability.Undetermined;
256+
}
250257
else
251258
{
252259
//try to find out if PSRAM is present
253-
psramIsAvailable = FindPSRamAvailable(
254-
out psRamSize,
255-
forcePsRamCheck);
260+
psramIsAvailable = FindPSRamAvailable(out psRamSize, forcePsRamCheck);
256261
}
257262

258263
if (Verbosity >= VerbosityLevel.Normal)

0 commit comments

Comments
 (0)