Sonar happiness

Author: networkfusion

nanoFramework.Aws.IoTCore.Devices/AwsSignatureVersion4/SignerBase.cs

@@ -44,7 +44,7 @@ public abstract class SignerBase
 
         // algorithm used to hash the canonical request that is supplied to
         // the signature computation
-        internal static SHA256 CanonicalRequestHashAlgorithm = SHA256.Create();
+        internal static readonly SHA256 CanonicalRequestHashAlgorithm = SHA256.Create();
 
         /// <summary>
         /// The service endpoint, including the path to any resource.

nanoFramework.Aws.IoTCore.Devices/AwsSignatureVersion4/SignerForAuthorizationHeader.cs

@@ -57,7 +57,7 @@ public string ComputeSignature(IDictionary headers,
             headers.Add(X_Amz_Date, dateTimeStamp);
 
             var hostHeader = EndpointUri.Host;
-            hostHeader += ":" + EndpointUri.Port; // FIXME: should use //if (!EndpointUri.IsDefaultPort)
+            hostHeader += ":" + EndpointUri.Port; // TODO: should use //if (!EndpointUri.IsDefaultPort)
             headers.Add("Host", hostHeader);
 
             // canonicalize the headers; we need the set of header names as well as the

nanoFramework.Aws.IoTCore.Devices/AwsSignatureVersion4/SignerForChunkedUpload.cs

@@ -92,7 +92,7 @@ public string ComputeSignature(IDictionary headers,
             headers.Add(X_Amz_Date, DateTimeStamp);
 
             var hostHeader = EndpointUri.Host;
-            hostHeader += ":" + EndpointUri.Port; // FIXME: should use //if (!EndpointUri.IsDefaultPort)
+            hostHeader += ":" + EndpointUri.Port; // TODO: should use //if (!EndpointUri.IsDefaultPort)
             headers.Add("Host", hostHeader);
 
             // canonicalize the headers; we need the set of header names as well as the

nanoFramework.Aws.IoTCore.Devices/AwsSignatureVersion4/SignerForPOST.cs

@@ -72,7 +72,7 @@ public string ComputeSignature(IDictionary headers,
             headers.Add(X_Amz_Date, dateTimeStamp);
 
             var hostHeader = EndpointUri.Host;
-            hostHeader += ":" + EndpointUri.Port; // FIXME: should use //if (!EndpointUri.IsDefaultPort)
+            hostHeader += ":" + EndpointUri.Port; // TODO: should use //if (!EndpointUri.IsDefaultPort)
             headers.Add("Host", hostHeader);
 
             // canonicalize the headers; we need the set of header names as well as the

nanoFramework.Aws.IoTCore.Devices/AwsSignatureVersion4/SignerForQueryParameterAuth.cs

@@ -59,7 +59,7 @@ public string ComputeSignature(IDictionary headers,
             if (!headers.Contains("Host"))
             {
                 var hostHeader = EndpointUri.Host;
-                hostHeader += ":" + EndpointUri.Port; // FIXME: should use //if (!EndpointUri.IsDefaultPort)
+                hostHeader += ":" + EndpointUri.Port; // TODO: should use //if (!EndpointUri.IsDefaultPort)
                 headers.Add("Host", hostHeader);
             }
 

nanoFramework.Aws.IoTCore.Devices/WebsocketConnectionClient.cs

@@ -34,7 +34,7 @@ public class WebsocketConnectionClient : IDisposable
 
         const int _wssPort = 443; //Default WSS port.
 
-        //WebSocket _webSocket = null;
+        private WebSocket _webSocket = null;
 
         /// <summary>
         /// Creates a new MQTT over WebSocket Connection Client
@@ -44,6 +44,8 @@ public class WebsocketConnectionClient : IDisposable
         /// </remarks>
         public WebsocketConnectionClient()
         {
+            //_webSocket = new WebSocket();
+
             // TODO: implement! look to the following:
             // https://github.com/dotnet/MQTTnet/blob/master/Source/MQTTnet.Extensions.WebSocket4Net/WebSocket4NetMqttChannel.cs
 
@@ -66,6 +68,12 @@ public WebsocketConnectionClient()
         /// <inheritdoc/>
         public void Dispose()
         {
+            if (_webSocket != null)
+            {
+                // Cleaning
+                GC.SuppressFinalize(_webSocket);
+                _webSocket = null;
+            }
 
         }
     }