Improvements in telemetry (#180)

***NO_CI***

Author: josesimoes

nanoFramework.Azure.Devices.Client/DeviceClient.cs

@@ -222,13 +222,7 @@ public bool Open()
                 userName += $"&model-id={HttpUtility.UrlEncode(ModelId)}";
             }
 
-            // compose product info
-            string productInfo = "nano;";
-            productInfo += $"azrsdk{ThisAssembly.AssemblyInformationalVersion};";
-            productInfo += $"{Runtime.Native.SystemInfo.TargetName}";
-
-            // add to user name
-            userName += $"&DeviceClientType={HttpUtility.UrlEncode(productInfo)}";
+            Helper.ComposeTelemetryInformation(ref userName);
 
             // Now connect the device
             string key = _isCertificate ? _privateKey : Helper.GetSharedAccessSignature(null, _sasKey, $"{_iotHubName}/devices/{_deviceId}", new TimeSpan(24, 0, 0));

nanoFramework.Azure.Devices.Client/Helper.cs

@@ -43,5 +43,16 @@ public static string GetSharedAccessSignature(string keyName, string sharedAcces
                     HttpUtility.UrlEncode(expiry));
             }
         }
+
+        public static void ComposeTelemetryInformation(ref string userName)
+        {
+            // compose product info
+            string productInfo = "nano;";
+            productInfo += $"azrsdk{ThisAssembly.AssemblyVersion};";
+            productInfo += $"{Runtime.Native.SystemInfo.TargetName}";
+
+            // add to user name
+            userName += $"&DeviceClientType={HttpUtility.UrlEncode(productInfo)}";
+        }
     }
 }

nanoFramework.Azure.Devices.Client/ProvisioningDeviceClient.cs

@@ -76,14 +76,18 @@ private ProvisioningDeviceClient(string globalDeviceEndpoint, string idScope, st
                deviceCert,
                MqttSslProtocols.TLSv1_2);
 
+            string userName = $"{idScope}/registrations/{_registrationId}/api-version=2019-03-31";
+
+            Helper.ComposeTelemetryInformation(ref userName);
+
             // Handler for received messages on the subscribed topics
             _mqttc.MqttMsgPublishReceived += ClientMqttMsgReceived;
 
             // Now connect the device
             string key = securityProvider != null ? Helper.GetSharedAccessSignature(null, securityProvider, $"{idScope}/registrations/{_registrationId}", new TimeSpan(24, 0, 0)) : string.Empty;
             _mqttc.Connect(
                 _registrationId,
-                $"{idScope}/registrations/{_registrationId}/api-version=2019-03-31",
+                userName,
                 key,
                 false,
                 MqttQoSLevel.ExactlyOnce,