Update 2 NuGet dependencies #362
Conversation
Bumps Nerdbank.GitVersioning from 3.6.146 to 3.7.112</br>Bumps nanoFramework.System.IO.FileSystem from 1.1.54 to 1.1.66</br> [version update] ###⚠️ This is an automated update.⚠️
WalkthroughThis pull request involves updating dependency versions across multiple projects within the nanoFramework ecosystem. The primary changes focus on two key dependencies: Changes
Possibly related PRs
Suggested labels
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
nanoFramework.CoreInk/packages.lock.json (1)
109-111: LGTM! Consider documenting version policy.The version update maintains consistency across all projects. Consider documenting the version policy for Nerdbank.GitVersioning in the repository to help with future updates.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (30)
Tests/FireTestApp/FireTestApp.nfprojis excluded by none and included by noneTests/FireTestApp/packages.configis excluded by none and included by noneTests/M5Core2TestApp/M5Core2TestApp.nfprojis excluded by none and included by noneTests/M5Core2TestApp/packages.configis excluded by none and included by noneTests/M5CoreTestApp/M5CoreTestApp.nfprojis excluded by none and included by noneTests/M5CoreTestApp/packages.configis excluded by none and included by noneTests/ToughTestApp/ToughTestApp.nfprojis excluded by none and included by noneTests/ToughTestApp/packages.configis excluded by none and included by nonenanoFramework.AtomLite/nanoFramework.AtomLite.nfprojis excluded by none and included by nonenanoFramework.AtomLite/packages.configis excluded by none and included by nonenanoFramework.AtomMatrix/nanoFramework.AtomMatrix.nfprojis excluded by none and included by nonenanoFramework.AtomMatrix/packages.configis excluded by none and included by nonenanoFramework.CoreInk/nanoFramework.CoreInk.nfprojis excluded by none and included by nonenanoFramework.CoreInk/packages.configis excluded by none and included by nonenanoFramework.Fire.nuspecis excluded by none and included by nonenanoFramework.Fire/nanoFramework.Fire.nfprojis excluded by none and included by nonenanoFramework.Fire/packages.configis excluded by none and included by nonenanoFramework.M5Core.nuspecis excluded by none and included by nonenanoFramework.M5Core/nanoFramework.M5Core.nfprojis excluded by none and included by nonenanoFramework.M5Core/packages.configis excluded by none and included by nonenanoFramework.M5Core2.nuspecis excluded by none and included by nonenanoFramework.M5Core2/nanoFramework.M5Core2.nfprojis excluded by none and included by nonenanoFramework.M5Core2/packages.configis excluded by none and included by nonenanoFramework.M5StickC/nanoFramework.M5StickC.nfprojis excluded by none and included by nonenanoFramework.M5StickC/packages.configis excluded by none and included by nonenanoFramework.M5StickCPlus/nanoFramework.M5StickCPlus.nfprojis excluded by none and included by nonenanoFramework.M5StickCPlus/packages.configis excluded by none and included by nonenanoFramework.Tough.nuspecis excluded by none and included by nonenanoFramework.Tough/nanoFramework.Tough.nfprojis excluded by none and included by nonenanoFramework.Tough/packages.configis excluded by none and included by none
📒 Files selected for processing (13)
Tests/FireTestApp/packages.lock.json(1 hunks)Tests/M5Core2TestApp/packages.lock.json(1 hunks)Tests/M5CoreTestApp/packages.lock.json(1 hunks)Tests/ToughTestApp/packages.lock.json(1 hunks)nanoFramework.AtomLite/packages.lock.json(1 hunks)nanoFramework.AtomMatrix/packages.lock.json(1 hunks)nanoFramework.CoreInk/packages.lock.json(1 hunks)nanoFramework.Fire/packages.lock.json(2 hunks)nanoFramework.M5Core/packages.lock.json(2 hunks)nanoFramework.M5Core2/packages.lock.json(2 hunks)nanoFramework.M5StickC/packages.lock.json(1 hunks)nanoFramework.M5StickCPlus/packages.lock.json(1 hunks)nanoFramework.Tough/packages.lock.json(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- nanoFramework.Tough/packages.lock.json
🔇 Additional comments (11)
nanoFramework.AtomLite/packages.lock.json (1)
79-81: LGTM! Verify the stability of Nerdbank.GitVersioning 3.7.112.
The version update is consistent with the PR objectives. Since this tool is crucial for versioning, let's verify its stability.
✅ Verification successful
Version 3.7.112 of Nerdbank.GitVersioning is stable and safe to use
This is a stable release published on December 12, 2024, with no reported issues. The release includes several improvements and bug fixes, notably:
- Better tag detection for PublicRelease
- Performance improvements
- Bug fixes for version height and commit date handling
- Enhanced MSBuild integration
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for any reported issues with Nerdbank.GitVersioning 3.7.112
gh api graphql -f query='
{
repository(owner: "dotnet", name: "Nerdbank.GitVersioning") {
release(tagName: "v3.7.112") {
url
isPrerelease
isDraft
}
}
}'
Length of output: 338
Script:
#!/bin/bash
# Check if there are any open issues mentioning this specific version
gh api graphql -f query='
{
search(query: "repo:dotnet/Nerdbank.GitVersioning 3.7.112 is:issue state:open", type: ISSUE, first: 10) {
nodes {
... on Issue {
title
url
createdAt
}
}
}
}
'
# Let's also check the release date and description
gh api graphql -f query='
{
repository(owner: "dotnet", name: "Nerdbank.GitVersioning") {
release(tagName: "v3.7.112") {
publishedAt
description
}
}
}'
Length of output: 3439
nanoFramework.AtomMatrix/packages.lock.json (1)
109-111: LGTM! Consistent version update across projects.
The version update maintains consistency with other projects in the solution.
Tests/ToughTestApp/packages.lock.json (1)
85-87: Verify compatibility with nanoFramework.System.IO.FileSystem 1.1.66
The dependency update from 1.1.54 to 1.1.66 matches the PR objectives. Let's verify the changelog for any breaking changes.
✅ Verification successful
Update to nanoFramework.System.IO.FileSystem 1.1.66 appears safe
Based on the changelog between versions 1.1.54 and 1.1.66, the updates include:
- Bug fix for SD card functionality
- Additional unit tests for FileSystemInfo and hidden/system files
- Enhancement adding nativefilestream and new methods to
FileandFileStream
These changes are additive and include bug fixes, with no indication of breaking changes or deprecations that would impact existing functionality.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for breaking changes in the changelog between versions
gh api repos/nanoframework/System.IO.FileSystem/releases | jq -r '.[] | select(.tag_name | contains("v1.1.")) | select(.tag_name >= "v1.1.54" and .tag_name <= "v1.1.66") | .body'
Length of output: 766
nanoFramework.M5StickC/packages.lock.json (1)
127-129: Verify Nerdbank.GitVersioning update impact on build process
The update from 3.6.146 to 3.7.112 matches the PR objectives. Since this is a development dependency that affects versioning, let's verify the changelog for any changes that might impact the build process.
✅ Verification successful
Update to Nerdbank.GitVersioning 3.7.112 is safe for the build process
Based on the changelog between versions 3.6.146 and 3.7.112, there are no breaking changes that would negatively impact the build process. The changes include:
- Build improvements (e.g., ensuring GetBuildVersion runs before Clean)
- Bug fixes for tag handling and commit dates
- New optional features (e.g., package version in ThisAssembly class)
- Internal dependency updates and code improvements
The most significant change is retargeting from net462 to net472, but this doesn't affect the tool's functionality in the build process.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for breaking changes in the changelog between versions
gh api repos/dotnet/Nerdbank.GitVersioning/releases | jq -r '.[] | select(.tag_name | contains("v3.")) | select(.tag_name >= "v3.6.146" and .tag_name <= "v3.7.112") | .body'
Length of output: 6502
Tests/M5CoreTestApp/packages.lock.json (1)
121-123: LGTM: Consistent version update across test applications
The update to nanoFramework.System.IO.FileSystem 1.1.66 is consistent with other test applications in the PR.
nanoFramework.M5StickCPlus/packages.lock.json (1)
139-141: LGTM! Verify changelog for breaking changes.
The Nerdbank.GitVersioning update from 3.6.146 to 3.7.112 appears correct and matches the PR objectives.
✅ Verification successful
Nerdbank.GitVersioning update is safe to proceed
The changelog between v3.6.146 and v3.7.112 shows no breaking changes. The updates primarily include:
- New features (e.g., package version in ThisAssembly class, customizable commit messages)
- Bug fixes (tag lookups, commit date handling)
- Internal improvements (retargeting, dependency updates)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for breaking changes in Nerdbank.GitVersioning changelog between versions
# Fetch the changelog or release notes
gh api repos/dotnet/Nerdbank.GitVersioning/releases \
--jq '.[] | select(.tag_name | contains("v3.7.112") or contains("v3.6.146")) | {tag_name, body}'
Length of output: 3364
Tests/FireTestApp/packages.lock.json (1)
139-141: LGTM! Verify test compatibility.
The nanoFramework.System.IO.FileSystem update from 1.1.54 to 1.1.66 appears correct and matches the PR objectives.
✅ Verification successful
The previous results show that the update from v1.1.54 to v1.1.66 mainly includes bug fixes for SD card handling and improvements in unit tests, with no breaking changes. However, we need to verify the actual usage in test files to ensure compatibility.
The previous results show that while FileSystem is referenced in project configuration files, we need to check the actual usage in code files to make an informed decision about the compatibility of the update.
From the previous results, we can see that System.IO.FileSystem is referenced as a dependency in the project file, but we need to check the actual usage in the code files to understand if the update from 1.1.54 to 1.1.66 (which includes SD card fixes and unit test improvements) would affect this test application.
LGTM! Update appears safe to proceed.
The update from System.IO.FileSystem 1.1.54 to 1.1.66 is safe as the test application doesn't actively use any FileSystem operations. The package is only referenced as a dependency but not utilized in the code. The changes in v1.1.66 (SD card fixes and unit test improvements) won't impact this test application.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for breaking changes in nanoFramework.System.IO.FileSystem changelog
# Fetch the changelog or release notes
gh api repos/nanoframework/System.IO.FileSystem/releases \
--jq '.[] | select(.tag_name | contains("v1.1.66") or contains("v1.1.54")) | {tag_name, body}'
# Look for any test files that might be affected
fd -e cs -e vb --exec rg -l "System\.IO\.FileSystem"
Length of output: 936
Script:
#!/bin/bash
# Let's check the test files in FireTestApp directory for any FileSystem usage
rg -l "System\.IO\.FileSystem" Tests/FireTestApp/
# Also check if there are any test files in the repository that use FileSystem
fd -e cs -p ".*test.*" --exec rg -l "System\.IO\.FileSystem" {}
# Check the FireTestApp project file for dependencies
cat Tests/FireTestApp/*.csproj
Length of output: 323
Script:
#!/bin/bash
# Let's check the actual content of these files to understand the FileSystem usage
cat Tests/FireTestApp/FireTestApp.nfproj
# Check for any actual code files in FireTestApp that might use FileSystem
fd -e cs -e vb Tests/FireTestApp/ --exec rg -A 5 "System\.IO\.FileSystem" {}
# Check if there are any test files in the repository root
fd -e cs -p "test" --exec rg -A 5 "System\.IO\.FileSystem" {}
Length of output: 10337
Script:
#!/bin/bash
# Let's check the Program.cs in FireTestApp for actual FileSystem usage
cat Tests/FireTestApp/Program.cs
# Check if there are any test files in the repository that use FileSystem with corrected fd syntax
fd -e cs . Tests/FireTestApp --exec rg -A 5 "System\.IO\.FileSystem" {}
Length of output: 5635
nanoFramework.M5Core/packages.lock.json (1)
133-135: LGTM! Both dependency updates are consistent.
The updates to both dependencies are correct and match the PR objectives:
- nanoFramework.System.IO.FileSystem: 1.1.54 -> 1.1.66
- Nerdbank.GitVersioning: 3.6.146 -> 3.7.112
Also applies to: 175-177
nanoFramework.Fire/packages.lock.json (1)
145-147: Dependency updates look good!
The following dependencies have been updated correctly:
- nanoFramework.System.IO.FileSystem: 1.1.66
- Nerdbank.GitVersioning: 3.7.112
Version ranges are properly locked and content hashes are updated.
Let's verify these are the latest stable versions:
Also applies to: 187-189
✅ Verification successful
Dependencies are updated to the latest stable versions
The package versions in packages.lock.json match the latest stable versions from NuGet.org:
- nanoFramework.System.IO.FileSystem: 1.1.66
- Nerdbank.GitVersioning: 3.7.112
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check latest versions of the updated packages
# Check NuGet.org for latest versions
curl -s https://api.nuget.org/v3-flatcontainer/nanoframework.system.io.filesystem/index.json | jq -r '.versions[]' | sort -V | tail -n 1
curl -s https://api.nuget.org/v3-flatcontainer/nerdbank.gitversioning/index.json | jq -r '.versions[]' | sort -V | tail -n 1
Length of output: 280
Tests/M5Core2TestApp/packages.lock.json (1)
145-147: Dependency update looks good!
The nanoFramework.System.IO.FileSystem package has been updated correctly to version 1.1.66 with proper version range locking and updated content hash.
nanoFramework.M5Core2/packages.lock.json (1)
151-153: Dependency updates look good!
The following dependencies have been updated correctly:
- nanoFramework.System.IO.FileSystem: 1.1.66
- Nerdbank.GitVersioning: 3.7.112
Version ranges are properly locked and content hashes are updated. The changes are consistent across all package.lock.json files.
Also applies to: 199-201
nfbot
deleted the
nfbot/update-dependencies/e3954e17-d2e9-472c-865d-e2f26d2c0d69
branch
Bumps Nerdbank.GitVersioning from 3.6.146 to 3.7.112
Bumps nanoFramework.System.IO.FileSystem from 1.1.54 to 1.1.66
[version update]
Summary by CodeRabbit
New Features
nanoFramework.System.IO.FileSystemupdated from1.1.54to1.1.66.Nerdbank.GitVersioningupdated from3.6.146to3.7.112.Bug Fixes