-
-
Notifications
You must be signed in to change notification settings - Fork 1
Added the benchmark project, general improvements, and the UnitTests add-on #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed unnecessary memory allocations. Fix deserialization of a single two-dimensional array and hashtable. Fix README samples and benchmark description. Updated UnitTest
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughFour new Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@RelaxSpirit we prefer to have "atomic" PR instead of adding a bulk of work (unless that makes more sense, of course). It makes it easier to review, keep the PR concise and even revert it, in case that is needed.
Thanks! |
|
@josesimoes Then you'll have to do PR with lock files first. |
|
I did a PR to add lock files. After confirming this PR and synchronizing my fork, it will be possible to make the remaining atomic PRs. |
|
The next part of the PR was done |
|
This PR was divided into three separate PRs. |
Removed unnecessary memory allocations.
Fix deserialization of a single two-dimensional array and hashtable.
Fix README samples and benchmark description.
Updated UnitTest
Description
Motivation and Context
Visual benchmark results are needed
How Has This Been Tested?
UnutTest, benchmarks in virtual nanoDevice
Types of changes
Checklist:
Summary by CodeRabbit