Skip to content

Conversation

@RelaxSpirit
Copy link
Collaborator

@RelaxSpirit RelaxSpirit commented Apr 19, 2025

Removed unnecessary memory allocations.
Fix deserialization of a single two-dimensional array and hashtable.
Fix README samples and benchmark description.
Updated UnitTest

Description

  1. Added a project with benchmark tests.
  2. Improved memory management when deserializing objects, removed unnecessary memory allocations.
  3. Added deserialization of two-dimensional arrays and hashtables directly, without using the parent class and additional converters.
  4. Updated the UnitTest verification of deserialization of objects.
  5. The README has been updated and corrected in terms of results benchmarks and usage examples.

Motivation and Context

Visual benchmark results are needed

How Has This Been Tested?

UnutTest, benchmarks in virtual nanoDevice

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Summary by CodeRabbit

  • Chores
    • Added lock files to ensure consistent dependency versions for NFUnitTest, nanoFramework.MessagePack.Benchmark, MsgPack.Tests, and nanoFramework.MessagePack.Net projects.

Removed unnecessary memory allocations.
Fix deserialization of a single two-dimensional array and hashtable.
Fix README samples and benchmark  description.
Updated UnitTest
@coderabbitai
Copy link

coderabbitai bot commented Apr 19, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • NFUnitTest/NFUnitTest.nfproj is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Four new packages.lock.json files have been added to the NFUnitTest, nanoFramework.MessagePack.Benchmark, MsgPack.Tests, and nanoFramework.MessagePack.Net project directories. These lock files record the exact versions and integrity hashes of all direct dependencies targeting either .NETnanoFramework,Version=v1.0 or .NET 9.0 for each project. The files ensure consistent and reproducible dependency resolution across environments. No code or API changes were introduced.

Changes

File(s) Change Summary
NFUnitTest/packages.lock.json Added lock file specifying exact versions and hashes for dependencies used by the NFUnitTest project targeting .NETnanoFramework,Version=v1.0.
nanoFramework.MessagePack.Benchmark/packages.lock.json Added lock file specifying exact versions and hashes for dependencies used by the nanoFramework.MessagePack.Benchmark project targeting .NETnanoFramework,Version=v1.0.
MsgPack.Tests/packages.lock.json Added lock file specifying exact versions, hashes, and dependency graph for NuGet packages used by the MsgPack.Tests project targeting .NET 9.0.
nanoFramework.MessagePack.Net/packages.lock.json Added lock file with empty dependencies object for the nanoFramework.MessagePack.Net project targeting .NET 9.0. No locked dependencies recorded.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RelaxSpirit RelaxSpirit self-assigned this Apr 19, 2025
@RelaxSpirit RelaxSpirit requested a review from josesimoes April 19, 2025 15:08
@josesimoes
Copy link
Member

@RelaxSpirit we prefer to have "atomic" PR instead of adding a bulk of work (unless that makes more sense, of course). It makes it easier to review, keep the PR concise and even revert it, in case that is needed.
Can you please, split this one in:

  1. General improvements (maybe add the unit tests there)
  2. changes in build system, with the addition of the lock files etc.
  3. Adding benchmark project and the readme entry for it

Thanks!

@RelaxSpirit
Copy link
Collaborator Author

@josesimoes Then you'll have to do PR with lock files first.
Confirm it. Then synchronize the fork.
Only after that, it will be possible to make two atomic PRs with the main changes, otherwise the Pull request will not pass the PR Checks.
Well, or deviate from the rules once and confirm this PR, especially since it is the first and, in fact, the project is still in the process of finalizing all necessary checks :)

@RelaxSpirit
Copy link
Collaborator Author

I did a PR to add lock files. After confirming this PR and synchronizing my fork, it will be possible to make the remaining atomic PRs.

@RelaxSpirit
Copy link
Collaborator Author

The next part of the PR was done

@RelaxSpirit
Copy link
Collaborator Author

This PR was divided into three separate PRs.

@RelaxSpirit RelaxSpirit deleted the benchmark branch April 21, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants