Skip to content

Commit 16ad0f8

Browse files
committed
Fix Coderabbit issues and add P4 to Azure build
1 parent fb2c353 commit 16ad0f8

File tree

6 files changed

+3
-8081
lines changed

6 files changed

+3
-8081
lines changed

CMake/Modules/ESP32_P4_GCC_options.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ macro(nf_set_compile_options)
2121
target_compile_options(${NFSCO_TARGET} PUBLIC ${NFSCO_EXTRA_COMPILE_OPTIONS} -Wall -Wextra -Werror -Wno-sign-compare -Wno-unused-parameter -Wshadow -Wimplicit-fallthrough -fshort-wchar -fno-builtin -fno-common -fno-exceptions -fcheck-new )
2222

2323
# this series has FPU
24-
target_compile_definitions(${NFSCO_TARGET} PUBLIC -DTARGET=esp32c6 -DUSE_FPU=TRUE -DPLATFORM_ESP32 -DESP_PLATFORM)
24+
target_compile_definitions(${NFSCO_TARGET} PUBLIC -DTARGET=esp32p4 -DUSE_FPU=TRUE -DPLATFORM_ESP32 -DESP_PLATFORM)
2525

2626
endmacro()
2727

targets/ESP32/ESP32_P4/nanoCLR/nanoFramework.Graphics/Spi_To_TouchPanel.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@
55

66
#define UNUSED(x) (void)x
77

8-
#ifndef SPI_TO_TOUCHPANEL_H
9-
#define SPI_TO_TOUCHPANEL_H
10-
8+
#ifndef SPI_TO_TOUCHPANEL_CPP
9+
#define SPI_TO_TOUCHPANEL_CPP
1110
#include "nanoCLR_Types.h"
1211
#include <nanoPAL.h>
1312
#include <target_platform.h>

targets/ESP32/_IDF/sdkconfig.default.esp32s2

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ CONFIG_IDF_TARGET="esp32s2"
88
# Deprecated drivers, disable warnings on build
99
CONFIG_ADC_SUPPRESS_DEPRECATE_WARN=y
1010
CONFIG_ADC_CALI_SUPPRESS_DEPRECATE_WARN=y
11-
CONFIG_UART_ISR_IN_IRAM=y
1211
CONFIG_PCNT_SUPPRESS_DEPRECATE_WARN=y
1312
CONFIG_RMT_SUPPRESS_DEPRECATE_WARN=y
1413
CONFIG_I2S_SUPPRESS_DEPRECATE_WARN=y

0 commit comments

Comments
 (0)