Replace setting MDP path with copy over

- Required because VS tries to load MDP from the directory and then all the other DLLs are missing.
- Should be reviewed upstream in order to pack all the directory.

Author: josesimoes

azure-pipelines-templates/check-mdp-for-build.yml

@@ -68,8 +68,26 @@ steps:
         eq(variables['DownloadMDP'], true),
         ne(variables['MDP_BUILDID'], '')
       )
-    displayName: Set MDP path
+    displayName: Copy MDP to build tool
     inputs:
       targetType: 'inline'
       script: |
-        Write-Host "##vso[task.setvariable variable=NF_MDP_MSBUILDTASK_PATH]$(Pipeline.Workspace)\mdp"
+        # Find which VS version is installed
+        $VsWherePath = "${env:PROGRAMFILES(X86)}\Microsoft Visual Studio\Installer\vswhere.exe"
+
+        Write-Output "VsWherePath is: $VsWherePath"
+
+        $VsInstance = $(&$VSWherePath -latest -property displayName)
+
+        Write-Output "Latest VS is: $VsInstance"
+
+        # copy MDP file to msbuild location
+        $VsPath = $(&$VsWherePath -latest -property installationPath)
+
+        Write-Debug "Copy MDP DLL to msbuild location"
+
+        $msbuildPath = $VsPath + "\MSBuild"
+
+        $extensionPath = $msbuildPath + "\nanoFramework\v1.0"
+
+        Copy-Item -Path "$env:Pipeline_Workspace\mdp" -Destination $msbuildPath -Recurse

azure-pipelines.yml

@@ -90,7 +90,7 @@ jobs:
             # get commit details, if this is a PR
             if($env:System_PullRequest_PullRequestId -ne $null)
             {
-              Write-Host "##[command] **This is a PR build**"
+              Write-Host "**This is a PR build**"
 
               # compute authorization header in format "AUTHORIZATION: basic 'encoded token'"
               # 'encoded token' is the Base64 of the string "nfbot:personal-token"
@@ -100,7 +100,7 @@ jobs:
 
               if( ($commit.commit.author.name -eq "nfbot") -and ($commit.commit.message -like "*[version update]*") )
               {
-                Write-Host "##[command] **version update commit, skipping build**"
+                Write-Host "**version update commit, skipping build**"
                 echo "##vso[task.setvariable variable=SKIP_BUILD;isOutput=true]true"  
               }
               else
@@ -109,12 +109,12 @@ jobs:
               }
 
               # find PR
-              "Getting PR#$env:System_PullRequest_PullRequestNumber details..." | Write-Host -ForegroundColor White -NoNewline
+              "Getting PR #$env:System_PullRequest_PullRequestNumber details..." | Write-Host -ForegroundColor White -NoNewline
               $pr = Invoke-WebRequest "https://api.github.com/repos/$env:Build_Repository_Name/pulls/$env:System_PullRequest_PullRequestNumber" | ConvertFrom-Json
 
               if($($pr.number) -eq "$env:System_PullRequest_PullRequestNumber")
               {
-                '##[command] OK' | Write-Host -ForegroundColor Green
+                'OK' | Write-Host -ForegroundColor Green
               }
 
               # grab PR commit message
@@ -1288,7 +1288,6 @@ jobs:
         persistCredentials: true
 
       - template: azure-pipelines-templates/check-mscorlib-to-test.yml
-      - template: azure-pipelines-templates/check-mdp-for-build.yml
 
       # Download nanoclr from build artifacts
       - task: DownloadBuildArtifacts@1
@@ -1305,6 +1304,8 @@ jobs:
         inputs:
           GitHubToken: $(GitHubToken)
 
+      - template: azure-pipelines-templates/check-mdp-for-build.yml
+
       - template: azure-pipelines-templates/install-nuget.yml@templates
 
       - task: Cache@2