Fix load and store field IL instructions for value types in stack

- Now dealing properly with value types for structs assigned from stack and not from heap.
- Fixes in store and load field.

Author: josesimoes

src/CLR/Core/Interpreter.cpp

@@ -2568,8 +2568,41 @@ HRESULT CLR_RT_Thread::Execute_IL(CLR_RT_StackFrame &stackArg)
 
                     CLR_RT_HeapBlock *obj = &evalPos[0];
                     NanoCLRDataType dt = obj->DataType();
+   
+                    // If it's a byref, it must be a struct instance on the stack/heap
+                    bool instanceIsByRef =
+                        (obj->DataType() == DATATYPE_BYREF) || (obj->DataType() == DATATYPE_ARRAY_BYREF);
 
-                    NANOCLR_CHECK_HRESULT(CLR_RT_TypeDescriptor::ExtractObjectAndDataType(obj, dt));
+                    if (instanceIsByRef)
+                    {
+                        // extra check for DATATYPE_DATETIME and DATATYPE_TIMESPAN (special cases)
+                        if (obj->Dereference()->DataType() == DATATYPE_DATETIME ||
+                            obj->Dereference()->DataType() == DATATYPE_TIMESPAN)
+                        {
+                            NANOCLR_CHECK_HRESULT(CLR_RT_TypeDescriptor::ExtractObjectAndDataType(obj, dt));
+                        }
+                        else
+                        {
+                            // we already have a pointer to the raw struct
+                            dt = DATATYPE_VALUETYPE;
+
+                            obj = obj->Dereference();
+                            FAULT_ON_NULL(obj);
+                        }
+                    }
+                    else
+                    {
+                        // ordinary object/array
+                        FAULT_ON_NULL(obj);
+                        NANOCLR_CHECK_HRESULT(CLR_RT_TypeDescriptor::ExtractObjectAndDataType(obj, dt));
+                    }
+
+                    //if ((dt == DATATYPE_OBJECT || dt == DATATYPE_BYREF) && obj->Dereference() == NULL)
+                    //{
+                    //    NANOCLR_SET_AND_LEAVE(CLR_E_NULL_REFERENCE); 
+                    //}
+
+                    //NANOCLR_CHECK_HRESULT(CLR_RT_TypeDescriptor::ExtractObjectAndDataType(obj, dt));
 
                     switch (dt)
                     {
@@ -2665,9 +2698,35 @@ HRESULT CLR_RT_Thread::Execute_IL(CLR_RT_StackFrame &stackArg)
                     }
 
                     CLR_RT_HeapBlock *obj = &evalPos[1];
-                    NanoCLRDataType dt = obj->DataType();
+                    NanoCLRDataType dt;
 
-                    NANOCLR_CHECK_HRESULT(CLR_RT_TypeDescriptor::ExtractObjectAndDataType(obj, dt));
+                    // If it's a byref, it must be a struct instance on the stack/heap
+                    bool instanceIsByRef =
+                        (obj->DataType() == DATATYPE_BYREF) || (obj->DataType() == DATATYPE_ARRAY_BYREF);
+
+                    if (instanceIsByRef)
+                    {
+                        // extra check for DATATYPE_DATETIME and DATATYPE_TIMESPAN (special cases)
+                        if (obj->Dereference()->DataType() == DATATYPE_DATETIME ||
+                            obj->Dereference()->DataType() == DATATYPE_TIMESPAN)
+                        {
+                            NANOCLR_CHECK_HRESULT(CLR_RT_TypeDescriptor::ExtractObjectAndDataType(obj, dt));
+                        }
+                        else
+                        {
+                            // we already have a pointer to the raw struct
+                            dt = DATATYPE_VALUETYPE;
+
+                            // follow the byref so obj really points at the struct
+                            obj = obj->Dereference();
+                        }
+                    }
+                    else
+                    {
+                        // ordinary object/array
+                        FAULT_ON_NULL(obj);
+                        NANOCLR_CHECK_HRESULT(CLR_RT_TypeDescriptor::ExtractObjectAndDataType(obj, dt));
+                    }
 
                     switch (dt)
                     {