Improve initialization of Heap blocks and type related vars (#2883)

Author: josesimoes

src/CLR/CorLib/corlib_native_System_Array.cpp

@@ -14,6 +14,9 @@ HRESULT Library_corlib_native_System_Array::System_Collections_IList_get_Item___
     int index = stack.Arg1().NumericByRef().s4;
 
     CLR_RT_HeapBlock ref;
+
+    memset(&ref, 0, sizeof(struct CLR_RT_HeapBlock));
+
     NANOCLR_CHECK_HRESULT(ref.InitializeArrayReference(thisRef, index));
 
     {
@@ -36,6 +39,9 @@ HRESULT Library_corlib_native_System_Array::System_Collections_IList_set_Item___
     int index = stack.Arg1().NumericByRef().s4;
 
     CLR_RT_HeapBlock ref;
+
+    memset(&ref, 0, sizeof(struct CLR_RT_HeapBlock));
+
     NANOCLR_CHECK_HRESULT(ref.InitializeArrayReference(thisRef, index));
 
     NANOCLR_SET_AND_LEAVE(stack.Arg2().StoreToReference(ref, 0));

src/CLR/CorLib/corlib_native_System_Exception.cpp

@@ -42,17 +42,22 @@ HRESULT Library_corlib_native_System_Exception::get_StackTrace___STRING(CLR_RT_S
     NATIVE_PROFILE_CLR_CORE();
     NANOCLR_HEADER();
 
-    CLR_RT_HeapBlock_Array *pArray;
-    StackTrace *pStackTrace;
-    CLR_RT_HeapBlock *pBlkString;
     char buf[512];
     char *strName;
     size_t iName;
+    int depth = 0;
+
+    CLR_RT_HeapBlock_Array *pArray;
+    StackTrace *pStackTrace;
+    CLR_RT_HeapBlock *pBlkString;
     CLR_RT_HeapBlock tmpArray;
+    CLR_RT_HeapBlock *pThis;
+
+    memset(&tmpArray, 0, sizeof(struct CLR_RT_HeapBlock));
     tmpArray.SetObjectReference(NULL);
     CLR_RT_ProtectFromGC gc(tmpArray);
-    int depth = 0;
-    CLR_RT_HeapBlock *pThis = stack.This();
+
+    pThis = stack.This();
     FAULT_ON_NULL(pThis);
 
     pArray = pThis[FIELD___stackTrace].DereferenceArray();

src/CLR/CorLib/corlib_native_System_GC.cpp

@@ -36,7 +36,7 @@ HRESULT Library_corlib_native_System_GC::ReRegisterForFinalize___STATIC__VOID__O
     NATIVE_PROFILE_CLR_CORE();
     NANOCLR_HEADER();
 
-    CLR_RT_TypeDescriptor desc;
+    CLR_RT_TypeDescriptor desc{};
     CLR_RT_HeapBlock *pObj = stack.Arg0().Dereference();
     FAULT_ON_NULL(pObj);
 

src/CLR/CorLib/corlib_native_System_Number.cpp

@@ -962,7 +962,7 @@ HRESULT Library_corlib_native_System_Number::
     FAULT_ON_NULL(numberGroupSizes);
 
     {
-        CLR_RT_TypeDescriptor desc;
+        CLR_RT_TypeDescriptor desc{};
         NANOCLR_CHECK_HRESULT(desc.InitializeFromObject(*value));
         NANOCLR_CHECK_HRESULT(value->PerformUnboxing(desc.m_handlerCls));
     }

src/CLR/CorLib/corlib_native_System_Object.cpp

@@ -34,7 +34,7 @@ HRESULT Library_corlib_native_System_Object::GetType___SystemType(CLR_RT_StackFr
     NATIVE_PROFILE_CLR_CORE();
     NANOCLR_HEADER();
 
-    CLR_RT_TypeDescriptor desc;
+    CLR_RT_TypeDescriptor desc{};
     CLR_RT_ReflectionDef_Index idx;
     CLR_RT_HeapBlock &arg0 = stack.Arg0();
     CLR_RT_HeapBlock *pObj;

src/CLR/CorLib/corlib_native_System_Reflection_Assembly.cpp

@@ -295,6 +295,8 @@ HRESULT Library_corlib_native_System_Reflection_Assembly::Load___STATIC__SystemR
 
     header = (CLR_RECORD_ASSEMBLY *)array->GetFirstElement();
 
+    memset(&hbTimeout, 0, sizeof(struct CLR_RT_HeapBlock));
+
     // !! need to cast to CLR_INT64 otherwise it wont setup a proper timeout
     hbTimeout.SetInteger((CLR_INT64)2 * CLR_RT_Thread::c_TimeQuantum_Milliseconds * TIME_CONVERSION__TO_MILLISECONDS);
 

src/CLR/CorLib/corlib_native_System_Reflection_FieldInfo.cpp

@@ -19,6 +19,8 @@ HRESULT Library_corlib_native_System_Reflection_FieldInfo::SetValue___VOID__OBJE
     bool fValueType;
     CLR_RT_HeapBlock &srcVal = stack.Arg2();
     CLR_RT_HeapBlock val;
+
+    memset(&val, 0, sizeof(struct CLR_RT_HeapBlock));
     val.Assign(srcVal);
     CLR_RT_ProtectFromGC gc(val);
 

src/CLR/CorLib/corlib_native_System_Reflection_RuntimeFieldInfo.cpp

@@ -54,7 +54,7 @@ HRESULT Library_corlib_native_System_Reflection_RuntimeFieldInfo::get_FieldType_
     NATIVE_PROFILE_CLR_CORE();
     NANOCLR_HEADER();
 
-    CLR_RT_TypeDescriptor desc;
+    CLR_RT_TypeDescriptor desc{};
     CLR_RT_FieldDef_Instance fd;
     CLR_RT_HeapBlock *hbField = stack.Arg0().Dereference();
 
@@ -86,6 +86,8 @@ HRESULT Library_corlib_native_System_Reflection_RuntimeFieldInfo::GetValue___OBJ
     CLR_RT_HeapBlock *obj;
     CLR_RT_HeapBlock dst;
 
+    memset(&dst, 0, sizeof(struct CLR_RT_HeapBlock));
+
     NANOCLR_CHECK_HRESULT(Library_corlib_native_System_Reflection_FieldInfo::Initialize(stack, instFD, instTD, obj));
 
     fd = instFD.m_target;

src/CLR/CorLib/corlib_native_System_RuntimeType.cpp

@@ -183,7 +183,7 @@ HRESULT Library_corlib_native_System_RuntimeType::GetElementType___SystemType(CL
     NATIVE_PROFILE_CLR_CORE();
     NANOCLR_HEADER();
 
-    CLR_RT_TypeDescriptor desc;
+    CLR_RT_TypeDescriptor desc{};
     CLR_RT_TypeDescriptor descSub;
     CLR_RT_HeapBlock &top = stack.PushValueAndClear();
     CLR_RT_HeapBlock *hbType = stack.Arg0().Dereference();
@@ -342,7 +342,7 @@ HRESULT Library_corlib_native_System_RuntimeType::GetCustomAttributes(
             attributeEnumerator.GetCurrent(&instanceTypeDef);
 
             // setup attribute parser
-            CLR_RT_AttributeParser parser;
+            CLR_RT_AttributeParser parser{};
             NANOCLR_CHECK_HRESULT(parser.Initialize(attributeEnumerator));
 
             while (true)

src/CLR/CorLib/corlib_native_System_Runtime_CompilerServices_RuntimeHelpers.cpp

@@ -145,6 +145,8 @@ HRESULT Library_corlib_native_System_Runtime_CompilerServices_RuntimeHelpers::
                 CLR_RT_HeapBlock tmp;
                 CLR_UINT32 *ptr = (CLR_UINT32 *)ptrDst;
 
+                memset(&tmp, 0, sizeof(struct CLR_RT_HeapBlock));
+
                 for (; lenSrc; lenSrc--, ptr++)
                 {
                     NANOCLR_CHECK_HRESULT(tmp.SetFloatIEEE754(*ptr));
@@ -159,6 +161,8 @@ HRESULT Library_corlib_native_System_Runtime_CompilerServices_RuntimeHelpers::
                 CLR_RT_HeapBlock tmp;
                 CLR_UINT64 *ptr = (CLR_UINT64 *)ptrDst;
 
+                memset(&tmp, 0, sizeof(struct CLR_RT_HeapBlock));
+
                 for (; lenSrc; lenSrc--, ptr++)
                 {
                     NANOCLR_CHECK_HRESULT(tmp.SetDoubleIEEE754(*ptr));