Add error handling of SPI low level API

- Now processing return result and throwing exception with encoded error code on failure.
- Update declaration of ThrowError function.

Author: josesimoes

src/Com.SkyworksInc.NanoFramework.Devices.Spi/com_sky_nf_dev_spi_native.h

@@ -65,7 +65,7 @@ struct Library_com_sky_nf_dev_spi_native_Com_SkyworksInc_NanoFramework_Devices_S
     //--//
 
     static HRESULT ExecuteTransfer(CLR_RT_StackFrame &stack);
-    static HRESULT ThrowError(CLR_RT_StackFrame &stack, CLR_INT32 errorCode);
+    static HRESULT ThrowError(CLR_RT_StackFrame &stack, CLR_UINT32 errorCode);
 };
 
 struct Library_com_sky_nf_dev_spi_native_Com_SkyworksInc_NanoFramework_Devices_Spi_SpiException

targets/AzureRTOS/SiliconLabs/_nanoCLR/Com.SkyworksInc.NanoFramework.Devices.Spi/com_sky_nf_dev_spi_native_Com_SkyworksInc_NanoFramework_Devices_Spi_SpiBus.cpp

@@ -13,6 +13,7 @@ typedef Library_com_sky_nf_dev_spi_native_Com_SkyworksInc_NanoFramework_Devices_
 typedef Library_com_sky_nf_dev_spi_native_Com_SkyworksInc_NanoFramework_Devices_Spi_SpiBaseConfiguration
     SpiBaseConfiguration;
 typedef Library_corlib_native_System_SpanByte SpanByte;
+typedef Library_com_sky_nf_dev_spi_native_Com_SkyworksInc_NanoFramework_Devices_Spi_SpiException SpiException;
 
 static HRESULT SPI_nWrite_nRead(
     NF_PAL_SPI *palSpi,
@@ -119,7 +120,8 @@ bool System_Device_IsLongRunningOperation(
     }
 }
 
-HRESULT ExecuteTransfer(CLR_RT_StackFrame &stack)
+HRESULT Library_com_sky_nf_dev_spi_native_Com_SkyworksInc_NanoFramework_Devices_Spi_SpiBus::ExecuteTransfer(
+    CLR_RT_StackFrame &stack)
 {
     NANOCLR_HEADER();
 
@@ -135,6 +137,7 @@ HRESULT ExecuteTransfer(CLR_RT_StackFrame &stack)
     int16_t readOffset = 0;
     int16_t writeOffset = 0;
     bool fullDuplex;
+    int32_t operationResult;
 
     bool isLongRunningOperation;
     uint32_t estimatedDurationMiliseconds;
@@ -270,7 +273,7 @@ HRESULT ExecuteTransfer(CLR_RT_StackFrame &stack)
         // Start SPI transfer
         // We can ask for async transfer by setting callback but it depends if underlying supports it
         // return of CLR_E_BUSY means async started
-        hr = SPI_nWrite_nRead(
+        operationResult = SPI_nWrite_nRead(
             palSpi,
             SpiConfigs[busIndex - 1],
             rws,
@@ -280,10 +283,15 @@ HRESULT ExecuteTransfer(CLR_RT_StackFrame &stack)
             (int32_t)readSize);
 
         // Async transfer started, go to custom 2 state (wait completion)
-        if (hr == CLR_E_BUSY)
+        if (operationResult == CLR_E_BUSY)
         {
             stack.m_customState = 2;
         }
+        else if (operationResult != S_OK)
+        {
+            // Something went wrong with SPI transfer
+            NANOCLR_CHECK_HRESULT(ThrowError(stack, operationResult));
+        }
     }
 
     // Waiting for Async operation to complete
@@ -327,6 +335,7 @@ static HRESULT SPI_nWrite_nRead(
     NANOCLR_HEADER();
 
     bool busConfigIsHalfDuplex;
+    Ecode_t transferResult;
 
     // If callback then use async operation
     bool sync = (wrc.callback == 0);
@@ -382,7 +391,7 @@ static HRESULT SPI_nWrite_nRead(
             {
                 // Full duplex
                 // Uses the largest buffer size as transfer size
-                NF_SpiDriver_MTransferB(
+                transferResult = NF_SpiDriver_MTransferB(
                     palSpi->Handle,
                     palSpi->WriteBuffer,
                     palSpi->ReadBuffer,
@@ -397,7 +406,13 @@ static HRESULT SPI_nWrite_nRead(
                 //     // half duplex operation, set output enable
                 //     palSpi->Handle->spi->CR1 |= SPI_CR1_BIDIOE;
                 // }
-                NF_SpiDriver_MTransmitB(palSpi->Handle, palSpi->WriteBuffer, palSpi->WriteSize);
+                transferResult = NF_SpiDriver_MTransmitB(palSpi->Handle, palSpi->WriteBuffer, palSpi->WriteSize);
+
+                // bail out if the transmit operation failed
+                if (transferResult != ECODE_EMDRV_SPIDRV_OK)
+                {
+                    NANOCLR_SET_AND_LEAVE(transferResult);
+                }
 
                 // receive operation
                 // TODO
@@ -406,7 +421,7 @@ static HRESULT SPI_nWrite_nRead(
                 //     // half duplex operation, set output enable
                 //     palSpi->Handle->spi->CR1 &= ~SPI_CR1_BIDIOE;
                 // }
-                NF_SpiDriver_MReceiveB(palSpi->Handle, palSpi->ReadBuffer, palSpi->ReadSize);
+                transferResult = NF_SpiDriver_MReceiveB(palSpi->Handle, palSpi->ReadBuffer, palSpi->ReadSize);
             }
         }
         else
@@ -421,7 +436,7 @@ static HRESULT SPI_nWrite_nRead(
                 //     // half duplex operation, set output enable
                 //     palSpi->Handle->spi->CR1 &= ~SPI_CR1_BIDIOE;
                 // }
-                NF_SpiDriver_MReceiveB(palSpi->Handle, palSpi->ReadBuffer, palSpi->ReadSize);
+                transferResult = NF_SpiDriver_MReceiveB(palSpi->Handle, palSpi->ReadBuffer, palSpi->ReadSize);
             }
             else
             {
@@ -432,9 +447,11 @@ static HRESULT SPI_nWrite_nRead(
                     // half duplex operation, set output enable
                     // palSpi->Handle->spi->CR1 |= SPI_CR1_BIDIOE;
                 }
-                NF_SpiDriver_MTransmitB(palSpi->Handle, palSpi->WriteBuffer, palSpi->WriteSize);
+                transferResult = NF_SpiDriver_MTransmitB(palSpi->Handle, palSpi->WriteBuffer, palSpi->WriteSize);
             }
         }
+
+        NANOCLR_SET_AND_LEAVE(transferResult);
     }
     else
     {
@@ -658,3 +675,41 @@ HRESULT Library_com_sky_nf_dev_spi_native_Com_SkyworksInc_NanoFramework_Devices_
 
     NANOCLR_NOCLEANUP();
 }
+
+HRESULT Library_com_sky_nf_dev_spi_native_Com_SkyworksInc_NanoFramework_Devices_Spi_SpiBus::ThrowError(
+    CLR_RT_StackFrame &stack,
+    CLR_UINT32 errorCode)
+{
+    NANOCLR_HEADER();
+
+    SpiError spiErrorCode;
+
+    CLR_RT_HeapBlock &res = stack.m_owningThread->m_currentException;
+
+    if ((Library_corlib_native_System_Exception::CreateInstance(
+            res,
+            g_CLR_RT_WellKnownTypes.m_SocketException,
+            CLR_E_FAIL,
+            &stack)) == S_OK)
+    {
+        // Set the error code
+        if (errorCode == ECODE_EMDRV_SPIDRV_TIMEOUT)
+        {
+            spiErrorCode = SpiError_Timeout;
+        }
+        else if (errorCode == ECODE_EMDRV_SPIDRV_ABORTED)
+        {
+            spiErrorCode = SpiError_Aborted;
+        }
+        else
+        {
+            spiErrorCode = SpiError_Unknown;
+        }
+
+        res.Dereference()[SpiException::FIELD___errorCode].SetInteger((CLR_UINT32)spiErrorCode);
+    }
+
+    NANOCLR_SET_AND_LEAVE(CLR_E_PROCESS_EXCEPTION);
+
+    NANOCLR_NOCLEANUP();
+}