Fix BLE assembly declaration

[josesimoes]

Description

Motivation and Context

• Declaration wasn't correct due to missing assembly exclusion entry for MDP.
• Following nanoframework/nanoFramework.Device.Bluetooth@f25884b

How Has This Been Tested?

Screenshots

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue with code or algorithm)
• New feature (non-breaking change which adds functionality to code)
• Breaking change (fix or feature that would cause existing functionality to change)
• Config and build (change in the configuration and build system, has no impact on code or features)
• Dev Containers (changes related with Dev Containers, has no impact on code or features)
• Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
• Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

• My code follows the code style of this project (only if there are changes in source code).
• My changes require an update to the documentation (there are changes that require the docs website to be updated).
• I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• I have read the CONTRIBUTING document.
• I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

• Chores
  • Refined the Bluetooth module by updating its internal versioning to ensure stronger consistency and future proofing, supporting a more stable underlying operation.
• Refactor
  • Eliminated an outdated, unused configuration element to reduce complexity, promote efficient maintenance, and support smoother integration.

These internal changes bolster system reliability and maintainability without affecting the end-user experience.

[coderabbitai]

Walkthrough

This pull request updates the Bluetooth native assembly for ESP32. In the C++ source file, the version identifier is updated from 0xAA4B0676 to 0xE610B405 and an extraneous NULL entry is removed from the method_lookup array. In the header file, an unused structure (Library_sys_dev_ble_native_ThisAssembly) along with its static constant field has been removed. The overall functionality remains unchanged.

Changes

File	Change Summary
targets/ESP32/_nanoCLR/.../sys_dev_ble_native.cpp	Updated g_CLR_AssemblyNative_nanoFramework_Device_Bluetooth version from 0xAA4B0676 to 0xE610B405; removed a NULL entry from the method_lookup array.
targets/ESP32/_nanoCLR/.../sys_dev_ble_native.h	Removed the Library_sys_dev_ble_native_ThisAssembly structure containing the static constant field FIELD_STATIC__GitCommitDate.

Possibly related PRs

• Fix nanoFramework.Hardware.Esp32.Rmt signature #3127: Involves modifications to assembly identifiers and removal of NULL entries from method lookup arrays, aligning closely with the changes in this PR.
• Update mscorlib declaration #3123: Addresses changes in the method_lookup array and structure updates, which are similar to the updates made in this pull request.
• Update bluetooth checksum due to PR #82 #2966: Focuses on modifications to the g_CLR_AssemblyNative_nanoFramework_Device_Bluetooth structure and its version identifier, directly relating to the version update in this PR.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6937f24 and fdb46c2.

📒 Files selected for processing (2)

• targets/ESP32/_nanoCLR/nanoFramework.Device.Bluetooth/sys_dev_ble_native.cpp (1 hunks)
• targets/ESP32/_nanoCLR/nanoFramework.Device.Bluetooth/sys_dev_ble_native.h (0 hunks)

💤 Files with no reviewable changes (1)

• targets/ESP32/_nanoCLR/nanoFramework.Device.Bluetooth/sys_dev_ble_native.h

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: nf-interpreter (Check_Code_Style)
• GitHub Check: nf-interpreter (Nightly build) (Check_Build_Options)
• GitHub Check: nf-interpreter (Check_Build_Options)

🔇 Additional comments (1)

targets/ESP32/_nanoCLR/nanoFramework.Device.Bluetooth/sys_dev_ble_native.cpp (1)

827-827:

❓ Verification inconclusive

Version identifier updated correctly

The version identifier for the BLE assembly has been updated from the previous value (0xAA4B0676) to 0xE610B405. This change appears to align with the PR objective to fix the BLE assembly declaration by adding the missing assembly exclusion entry for MDP.

---

🏁 Script executed:

#!/bin/bash
# Check for any other references to the old version identifier in the codebase
# that might need to be updated for consistency

echo "Searching for any remaining references to the old version identifier..."
rg "0xAA4B0676" --type cpp

Length of output: 179

---

Version identifier update appears correct, but please verify manually

• The BLE assembly version identifier in targets/ESP32/_nanoCLR/nanoFramework.Device.Bluetooth/sys_dev_ble_native.cpp has been updated from 0xAA4B0676 to 0xE610B405.
• An automated search for 0xAA4B0676 (initially limited to C++ files) returned no matches. However, as the previous search produced no output, please manually verify (or run a repository‐wide check) to ensure no residual references exist in other file types or contexts.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.