chore(tests): add arrange/act/assert steps

Author: nanotaboada

tests/test_main.py

@@ -16,7 +16,9 @@ def test_given_get_when_request_path_has_no_id_then_response_status_code_should_
         when    request path has no ID
         then    response Status Code should be 200 OK
     """
+    # Act
     response = client.get(PATH)
+    # Assert
     assert response.status_code == 200
 
 
@@ -26,7 +28,9 @@ def test_given_get_when_request_path_has_no_id_then_response_body_should_be_coll
         when    request path has no ID
         then    response Status Code should be collection of players
     """
+    # Act
     response = client.get(PATH)
+    # Assert
     players = response.json()
     player_id = 0
     for player in players:
@@ -42,8 +46,11 @@ def test_given_get_when_request_path_is_nonexistent_id_then_response_status_code
         when    request path is nonexistent ID
         then    response Status Code should be 404 (Not Found)
     """
+    # Arrange
     player_id = nonexistent_player().id
+    # Act
     response = client.get(PATH + str(player_id))
+    # Assert
     assert response.status_code == 404
 
 
@@ -53,8 +60,11 @@ def test_given_get_when_request_path_is_existing_id_then_response_status_code_sh
         when    request path is existing ID
         then    response Status Code should be 200 (OK)
     """
+    # Arrange
     player_id = existing_player().id
+    # Act
     response = client.get(PATH + str(player_id))
+    # Assert
     assert response.status_code == 200
 
 
@@ -64,8 +74,11 @@ def test_given_get_when_request_path_is_existing_id_then_response_body_should_be
         when    request path is existing ID
         then    response body should be matching Player
     """
+    # Arrange
     player_id = existing_player().id
+    # Act
     response = client.get(PATH + str(player_id))
+    # Assert
     player = response.json()
     assert player["id"] == player_id
 
@@ -78,8 +91,11 @@ def test_given_get_when_request_path_is_nonexistent_squad_number_then_response_s
         when    request path is nonexistent Squad Number
         then    response Status Code should be 404 (Not Found)
     """
+    # Arrange
     squad_number = nonexistent_player().squad_number
+    # Act
     response = client.get(PATH + "squadnumber" + "/" + str(squad_number))
+    # Assert
     assert response.status_code == 404
 
 
@@ -89,8 +105,11 @@ def test_given_get_when_request_path_is_existing_squad_number_then_response_stat
         when    request path is existing Squad Number
         then    response Status Code should be 200 (OK)
     """
+    # Arrange
     squad_number = existing_player().squad_number
+    # Act
     response = client.get(PATH + "squadnumber" + "/" + str(squad_number))
+    # Assert
     assert response.status_code == 200
 
 
@@ -100,8 +119,11 @@ def test_given_get_when_request_path_is_existing_squad_number_then_response_body
         when    request path is existing Squad Number
         then    response body should be matching Player
     """
+    # Arrange
     squad_number = existing_player().squad_number
+    # Act
     response = client.get(PATH + "squadnumber" + "/" + str(squad_number))
+    # Assert
     player = response.json()
     assert player["squadNumber"] == squad_number
 
@@ -114,8 +136,11 @@ def test_given_post_when_request_body_is_empty_then_response_status_code_should_
         when    request body is empty
         then    response Status Code should be 422 (Unprocessable Entity)
     """
+    # Arrange
     body = {}
+    # Act
     response = client.post(PATH, data=body)
+    # Assert
     assert response.status_code == 422
 
 
@@ -125,9 +150,12 @@ def test_given_post_when_request_body_is_existing_player_then_response_status_co
         when    request body is existing Player
         then    response Status Code should be 409 (Conflict)
     """
+    # Arrange
     player = existing_player()
     body = json.dumps(player.__dict__)
+    # Act
     response = client.post(PATH, data=body)
+    # Assert
     assert response.status_code == 409
 
 
@@ -137,9 +165,12 @@ def test_given_post_when_request_body_is_nonexistent_player_then_response_status
         when    request body is nonexistent Player
         then    response Status Code should be 201 (Created)
     """
+    # Arrange
     player = nonexistent_player()
     body = json.dumps(player.__dict__)
+    # Act
     response = client.post(PATH, data=body)
+    # Assert
     assert response.status_code == 201
 
 # PUT /players/{player_id} -----------------------------------------------------
@@ -151,9 +182,12 @@ def test_given_put_when_request_body_is_empty_then_response_status_code_should_b
         when    request body is empty
         then    response Status Code should be 422 (Unprocessable Entity)
     """
+    # Arrange
     player_id = existing_player().id
     body = {}
+    # Act
     response = client.put(PATH + str(player_id), data=body)
+    # Assert
     assert response.status_code == 422
 
 
@@ -163,10 +197,13 @@ def test_given_put_when_request_path_is_unknown_id_then_response_status_code_sho
         when    request path is unknown ID
         then    response Status Code should be 404 (Not Found)
     """
+    # Arrange
     player_id = unknown_player().id
     player = unknown_player()
     body = json.dumps(player.__dict__)
+    # Act
     response = client.put(PATH + str(player_id), data=body)
+    # Assert
     assert response.status_code == 404
 
 
@@ -176,12 +213,15 @@ def test_given_put_when_request_path_is_existing_id_then_response_status_code_sh
         when    request path is existing ID
         then    response Status Code should be 204 (No Content)
     """
+    # Arrange
     player_id = existing_player().id
     player = existing_player()
     player.first_name = "Emiliano"
     player.middle_name = ""
     body = json.dumps(player.__dict__)
+    # Act
     response = client.put(PATH + str(player_id), data=body)
+    # Assert
     assert response.status_code == 204
 
 # DELETE /players/{player_id} --------------------------------------------------
@@ -193,8 +233,11 @@ def test_given_delete_when_request_path_is_unknown_id_then_response_status_code_
         when    request path is unknown ID
         then    response Status Code should be 404 (Not Found)
     """
+    # Arrange
     player_id = unknown_player().id
+    # Act
     response = client.delete(PATH + str(player_id))
+    # Assert
     assert response.status_code == 404
 
 
@@ -204,6 +247,9 @@ def test_given_delete_when_request_path_is_existing_id_then_response_status_code
         when    request path is existing ID
         then    response Status Code should be 204 (No Content)
     """
+    # Arrange
     player_id = 12  # nonexistent_player() previously created
+    # Act
     response = client.delete(PATH + str(player_id))
+    # Assert
     assert response.status_code == 204