Merge branch 'master' into chore/add-envrc

Author: nanotaboada

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,8 +1,8 @@
 ---
 name: Bug report
 about: Report a bug or unexpected behavior
-title: "[BUG]"
-labels: bug
+title: ''
+labels: bug, typescript
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1 @@
+blank_issues_enabled: false

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,7 +1,7 @@
 ---
 name: Feature request
 about: Propose a new feature or enhancement
-title: "[FEATURE]"
+title: ''
 labels: enhancement, typescript
 assignees: ''
 
@@ -15,17 +15,17 @@ What problem are you trying to solve? What's the pain point?
 
 Describe the expected behavior and functionality this feature will provide.
 
-## Suggested Approach
+## Suggested Approach _(optional)_
 
-Describe the technical implementation plan. Include architecture, key files/modules to modify, APIs, and any code patterns to follow.
+If known, describe the technical implementation plan. Include architecture, key files/modules to modify, APIs, and any code patterns to follow.
 
 ## Acceptance Criteria
 
 How will we know this feature is complete and working correctly?
 
-- [ ] Criterion 1
-- [ ] Criterion 2
-- [ ] Criterion 3
+- [ ] Feature behaves as described in the proposed solution
+- [ ] Tests are added or updated to cover the new functionality
+- [ ] No regressions in existing tests
 
 ## References
 

.github/copilot-instructions.md

@@ -149,6 +149,25 @@ Example: `feat(api): add player stats endpoint (#42)`
 - Port configuration (9000)
 - Production configurations or deployment secrets
 
+### Creating Issues
+
+This project uses Spec-Driven Development (SDD): discuss in Plan mode first, create a GitHub Issue as the spec artifact, then implement. Always offer to draft an issue before writing code.
+
+**Feature request** (`enhancement` label):
+- **Problem**: the pain point being solved
+- **Proposed Solution**: expected behavior and functionality
+- **Suggested Approach** *(optional)*: implementation plan if known
+- **Acceptance Criteria**: at minimum — behaves as proposed, tests added/updated, no regressions
+- **References**: related issues, docs, or examples
+
+**Bug report** (`bug` label):
+- **Description**: clear summary of the bug
+- **Steps to Reproduce**: numbered, minimal steps
+- **Expected / Actual Behavior**: one section each
+- **Environment**: runtime versions + OS
+- **Additional Context**: logs, screenshots, stack traces
+- **Possible Solution** *(optional)*: suggested fix or workaround
+
 ### Key workflows
 
 **Add an endpoint**:

.github/pull_request_template.md

@@ -0,0 +1,21 @@
+## Summary
+
+Brief description of the changes and why they were made.
+
+## Type of Change
+
+- [ ] `feat` — new feature
+- [ ] `fix` — bug fix
+- [ ] `chore` — maintenance, tooling, or dependency update
+- [ ] `docs` — documentation only
+- [ ] `test` — adding or updating tests
+- [ ] `refactor` — code change that neither fixes a bug nor adds a feature
+- [ ] `ci` — CI/CD changes
+- [ ] `perf` — performance improvement
+
+## Checklist
+
+- [ ] `CHANGELOG.md` updated
+- [ ] All tests pass
+- [ ] No regressions introduced
+- [ ] Follows project coding guidelines

CHANGELOG.md

@@ -50,6 +50,13 @@ This project uses football/soccer terminology for release names:
 
 ### Changed
 
+- `id` field in `Player` model migrated from `INTEGER` to `UUID` (`DataTypes.UUIDV4`, auto-generated on insert) — surrogate key, admin use only
+- `PUT /players/:id` route replaced by `PUT /players/squadNumber/:squadNumber` — natural key is now the domain identifier for mutations
+- `DELETE /players/:id` route replaced by `DELETE /players/squadNumber/:squadNumber` — natural key is now the domain identifier for mutations
+- `POST /players` conflict detection switched from `id`-based to `squadNumber`-based lookup
+- `IPlayer.id` type changed from `number` to `string` to reflect UUID
+- `updateAsync` and `deleteAsync` in service and database layers refactored to operate on `squadNumber`
+
 ### Deprecated
 
 ### Removed

package-lock.json

@@ -58,6 +58,7 @@
     "commitlint": "^20.5.0",
     "eslint": "^10.1.0",
     "eslint-config-prettier": "^10.1.8",
+    "globals": "^17.4.0",
     "jest": "^30.3.0",
     "nodemon": "^3.1.14",
     "pino-pretty": "^13.1.3",