fix(tests): address CodeRabbit review findings on PR #557

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: nanotaboada

CHANGELOG.md

@@ -60,11 +60,11 @@ This project uses football/soccer terminology for release names:
 
 - Player dataset normalised to November 2022 World Cup snapshot: Enzo Fernández (SL Benfica / Liga Portugal), Mac Allister (Brighton & Hove Albion), Messi (Paris Saint-Germain / Ligue 1), Di María `abbrPosition` → `RW`
 - Player UUIDs replaced with deterministic UUID v5 values (namespace `f201b13e-c670-473d-885d-e2be219f74c8`, formula `{firstName}-{lastName}`)
-- Test fixture for Create/Delete replaced: Paredes (squad 5) → Lo Celso (squad 27)
-- Test fixture for Update added: Emiliano Martínez (squad 23) — `firstName` `'Damián'` → `'Emiliano'`, `middleName` cleared
-- `playerStub.all` expanded to 26 players; `playerStub.update` added
+- Test fixtures renamed for clarity: `playerStub.nonexistent` (Lo Celso, squad 27 — not seeded, used for POST/DELETE) and `playerStub.existing` (Emiliano Martínez, squad 23 — always seeded, used for PUT)
+- `playerStub.all` expanded to 26 players
 - `PUT describe` in tests: removed `beforeEach`, added `afterEach` to restore Martínez; all tests retargeted to squad 23
 - `rest/players.rest` variables updated: `@newSquadNumber = 27`, `@existingSquadNumber = 23`
+- Docker: run `docker compose down -v` before `docker compose up` to pick up the rebuilt seeded DB from `storage/players-sqlite3.db` (see #551)
 
 ### Removed
 

rest/players.rest

@@ -154,6 +154,7 @@ Content-Type: application/json
 
 {
   "firstName": "Emiliano",
+  "middleName": null,
   "lastName": "Martínez",
   "dateOfBirth": "1992-09-02T00:00:00.000Z",
   "squadNumber": 23,

tests/player-test.ts

@@ -138,13 +138,13 @@ describe('Integration Tests', () => {
         });
     });
     describe('POST', () => {
-        it('Request POST /players within rate limit → Response processed', async () => {
+        it('Request POST /players within rate limit → Response status 201 Created', async () => {
             // Arrange
             const body = playerStub.nonexistent;
             // Act
             const response = await request(app).post('/players').send(body);
             // Assert
-            expect([201, 409]).toContain(response.status);
+            expect(response.status).toBe(201);
         });
         ((Number.parseInt(process.env.RATE_LIMIT_MAX_STRICT || '20', 10) >= 20) ? it.skip : it)('Request POST /players exceed rate limit → Response status 429 Too Many Requests', async () => {
             // This test is skipped by default as it requires making 20+ requests
@@ -273,9 +273,12 @@ describe('Integration Tests', () => {
     });
     describe('PUT', () => {
         afterEach(async () => {
-            await request(app)
+            const response = await request(app)
                 .put(`${path}/squadNumber/${playerStub.existing.squadNumber}`)
                 .send(playerStub.findBySquadNumber(playerStub.existing.squadNumber)); // restores original seeded data
+            if (response.status !== 204) {
+                throw new Error(`Restore failed with status ${response.status}`);
+            }
         });
 
         it('Request PUT /players/squadNumber/{squadNumber} within rate limit → Response status 204 No Content', async () => {