Skip to content

Commit 830b95b

Browse files
authored
Support singular form in uptime string (#6)
Sometimes the uptime is only "1 something", so we need the regex to accept those values.
1 parent 37ef8c2 commit 830b95b

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

napalm_servertech_pro2/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
def convert_uptime(uptime):
55
"""Converts a ServerTech uptime string to a number of seconds."""
66
time_regex = (
7-
r"^(?P<days>\d+) days (?P<hours>\d+) hours"
8-
r" (?P<minutes>\d+) minutes (?P<seconds>\d+) seconds$"
7+
r"^(?P<days>\d+) days? (?P<hours>\d+) hours?"
8+
r" (?P<minutes>\d+) minutes? (?P<seconds>\d+) seconds?$"
99
)
1010
m = re.match(
1111
time_regex,

tests/utils/test_utils.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@ def test_convert_uptime():
88
uptime = "11 days 4 hours 8 minutes 6 seconds"
99
assert utils.convert_uptime(uptime) == 965286
1010

11-
uptime = "0 days 0 hours 0 minutes 1 seconds"
11+
uptime = "133 days 1 hour 12 minutes 15 seconds"
12+
assert isinstance(utils.convert_uptime(uptime), int)
13+
14+
uptime = "0 days 0 hours 0 minutes 1 second"
1215
assert utils.convert_uptime(uptime) == 1
1316

1417
with pytest.raises(ValueError):

0 commit comments

Comments
 (0)