Skip to content

Commit 1aaebb6

Browse files
authored
Merge pull request #372 from sean-rice/370-use-collections-abc-mapping
use `collections.abc.Mapping`
2 parents 0f3c0c1 + a871733 commit 1aaebb6

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

napalm_logs/utils/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import socket
1414
import logging
1515
import threading
16-
import collections
16+
import collections.abc
1717
from pydoc import locate
1818
from datetime import datetime
1919

@@ -344,8 +344,8 @@ def dictupdate(dest, upd):
344344
Merges upd recursively into dest.
345345
'''
346346
recursive_update = True
347-
if (not isinstance(dest, collections.Mapping)) or (
348-
not isinstance(upd, collections.Mapping)
347+
if (not isinstance(dest, collections.abc.Mapping)) or (
348+
not isinstance(upd, collections.abc.Mapping)
349349
):
350350
raise TypeError('Cannot update using non-dict types in dictupdate.update()')
351351
updkeys = list(upd.keys())
@@ -358,8 +358,8 @@ def dictupdate(dest, upd):
358358
dest_subkey = dest.get(key, None)
359359
except AttributeError:
360360
dest_subkey = None
361-
if isinstance(dest_subkey, collections.Mapping) and isinstance(
362-
val, collections.Mapping
361+
if isinstance(dest_subkey, collections.abc.Mapping) and isinstance(
362+
val, collections.abc.Mapping
363363
):
364364
ret = dictupdate(dest_subkey, val)
365365
dest[key] = ret

0 commit comments

Comments
 (0)