Remove ucrt link logic

Author: Brooooooklyn

.cargo/config.toml

@@ -0,0 +1,2 @@
+[target.'cfg(target_env = "msvc")']
+rustflags = ["-C", "target-feature=+crt-static"]

.github/workflows/ci.yml

@@ -196,9 +196,3 @@ jobs:
             yarn build --target ${{ matrix.settings.target }}
             yarn build --target ${{ matrix.settings.target }} --release
           fi
-      - name: Build with static CRT
-        if: ${{ matrix.settings.target == 'x86_64-pc-windows-msvc' }}
-        working-directory: example
-        run: yarn build --target ${{ matrix.settings.target }} --release
-        env:
-          RUSTFLAGS: "-C target-feature=+crt-static -C link-arg=/FORCE:MULTIPLE"

libmimalloc-sys/build.rs

@@ -42,7 +42,8 @@ fn main() {
         cmake_config.define("MI_TRACK_ETW", "ON");
     }
 
-    if profile == "debug" {
+    // it's complicated to link ucrt in debug mode on windows
+    if profile == "debug" && target_env != "msvc" {
         cmake_config
             .define("MI_DEBUG_FULL", "ON")
             .define("MI_SHOW_ERRORS", "ON");
@@ -82,31 +83,22 @@ fn main() {
     if target_env == "msvc" {
         cmake_config
             .define("MI_USE_CXX", "ON")
-            .define("MI_WIN_USE_FIXED_TLS", "ON");
-        if !std::env::var("CARGO_CFG_TARGET_FEATURE")
-            .map(|s| s.contains("+crt-static"))
-            .unwrap_or(false)
-        {
-            if profile == "debug" {
-                println!("cargo:rustc-link-lib=ucrtd");
-            } else {
-                println!("cargo:rustc-link-lib=ucrt");
-            }
-        }
+            .define("MI_WIN_USE_FIXED_TLS", "ON")
+            // always turn off debug full and show errors on msvc
+            .define("MI_DEBUG_FULL", "OFF")
+            .define("MI_SHOW_ERRORS", "OFF")
+            .profile("release")
+            .static_crt(true);
     }
 
     let dst = cmake_config.build();
 
     if target_os == "windows" {
         println!(
-            "cargo:rustc-link-search=native={}/build/{}",
+            "cargo:rustc-link-search=native={}/build/Release",
             dst.display(),
-            if profile == "debug" {
-                "Debug"
-            } else {
-                "Release"
-            }
         );
+        println!("cargo:rustc-link-search=native={}/build", dst.display());
     } else {
         println!("cargo:rustc-link-search=native={}/build", dst.display());
     }