Skip to content

Commit 2d2a046

Browse files
ci: migrate from addnab/docker-run-action to tj-actions/docker-run (#1078)
* Initial plan * Migrate from addnab/docker-run-action to tj-actions/docker-run - Updated all 5 usages in .github/workflows/ci.yaml - Changed action from addnab/docker-run-action@v3 to tj-actions/docker-run@v2 - Renamed 'run' parameter to 'args' - Added required 'name' parameter with unique identifiers for each container - Container names include matrix node version for uniqueness across jobs Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com> * Fix docker-run multi-line args by wrapping with sh -c Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Brooooooklyn <3468483+Brooooooklyn@users.noreply.github.com>
1 parent 0b47125 commit 2d2a046

File tree

1 file changed

+15
-18
lines changed

1 file changed

+15
-18
lines changed

.github/workflows/ci.yaml

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -361,11 +361,12 @@ jobs:
361361
shell: bash
362362

363363
- name: Test bindings
364-
uses: addnab/docker-run-action@v3
364+
uses: tj-actions/docker-run@v2
365365
with:
366366
image: node:${{ matrix.node }}-slim
367+
name: test-linux-x64-gnu-${{ matrix.node }}
367368
options: -v ${{ github.workspace }}:/build -w /build
368-
run: yarn test -s
369+
args: yarn test -s
369370

370371
test-linux-x64-musl-binding:
371372
name: Test bindings on x86_64-unknown-linux-musl - node@${{ matrix.node }}
@@ -412,11 +413,12 @@ jobs:
412413
shell: bash
413414

414415
- name: Test bindings
415-
uses: addnab/docker-run-action@v3
416+
uses: tj-actions/docker-run@v2
416417
with:
417418
image: node:${{ matrix.node }}-alpine
419+
name: test-linux-x64-musl-${{ matrix.node }}
418420
options: -v ${{ github.workspace }}:/build -w /build
419-
run: |
421+
args: |
420422
yarn test -s
421423
422424
test-linux-aarch64-gnu-binding:
@@ -456,14 +458,12 @@ jobs:
456458
shell: bash
457459

458460
- name: Setup and run tests
459-
uses: addnab/docker-run-action@v3
461+
uses: tj-actions/docker-run@v2
460462
with:
461463
image: node:${{ matrix.node }}-slim
464+
name: test-linux-aarch64-gnu-${{ matrix.node }}
462465
options: --platform linux/arm64 -v ${{ github.workspace }}:/build -w /build
463-
run: |
464-
set -e
465-
yarn test -s
466-
ls -la
466+
args: sh -c "set -e && yarn test -s && ls -la"
467467

468468
test-linux-aarch64-musl-binding:
469469
name: Test bindings on aarch64-unknown-linux-musl - node@${{ matrix.node }}
@@ -503,13 +503,12 @@ jobs:
503503
shell: bash
504504

505505
- name: Setup and run tests
506-
uses: addnab/docker-run-action@v3
506+
uses: tj-actions/docker-run@v2
507507
with:
508508
image: node:lts-alpine
509+
name: test-linux-aarch64-musl-${{ matrix.node }}
509510
options: --platform linux/arm64 -v ${{ github.workspace }}:/build -w /build
510-
run: |
511-
set -e
512-
yarn test -s
511+
args: sh -c "set -e && yarn test -s"
513512

514513
test-linux-arm-gnueabihf-binding:
515514
name: Test bindings on armv7-unknown-linux-gnueabihf - node@${{ matrix.node }}
@@ -553,14 +552,12 @@ jobs:
553552
- run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
554553

555554
- name: Setup and run tests
556-
uses: addnab/docker-run-action@v3
555+
uses: tj-actions/docker-run@v2
557556
with:
558557
image: node:${{ matrix.node }}-bullseye-slim
558+
name: test-linux-arm-gnueabihf-${{ matrix.node }}
559559
options: --platform linux/arm/v7 -v ${{ github.workspace }}:/build -w /build
560-
run: |
561-
set -e
562-
yarn test -s
563-
ls -la
560+
args: sh -c "set -e && yarn test -s && ls -la"
564561

565562
test-wasi-nodejs:
566563
name: Test bindings on wasi - node@${{ matrix.node }}

0 commit comments

Comments
 (0)