fix(bcrypt): verify should always return boolean value

Author: Brooooooklyn

packages/bcrypt/__tests__/bcrypt.spec.ts

@@ -16,3 +16,9 @@ test('verifySync hashed password from @node-rs/bcrypt should be true', async (t)
   const hashed = await hash(fx)
   t.true(verifySync(fx, hashed))
 })
+
+test('verifySync should always return boolean even if the password is invalid', (t) => {
+  t.false(verifySync('a', 'b'))
+  t.false(verifySync('a', ''))
+  t.false(verifySync('', ''))
+})

packages/bcrypt/src/lib.rs

@@ -85,8 +85,7 @@ fn js_async_hash(ctx: CallContext) -> Result<JsObject> {
 fn js_verify(ctx: CallContext) -> Result<JsBoolean> {
   let password = ctx.get::<JsBuffer>(0)?.into_value()?;
   let hash = ctx.get::<JsBuffer>(1)?.into_value()?;
-  let result = VerifyTask::verify(&password, &hash)
-    .map_err(|e| Error::new(Status::GenericFailure, format!("{}", e)))?;
+  let result = VerifyTask::verify(&password, &hash)?;
   ctx.env.get_boolean(result)
 }
 

packages/bcrypt/src/verify_task.rs

@@ -15,11 +15,13 @@ impl VerifyTask {
 
   #[inline]
   pub fn verify(password: &[u8], hash: &[u8]) -> Result<bool> {
-    verify(
-      &password,
-      str::from_utf8(&hash).map_err(|_| Error::from_status(Status::StringExpected))?,
+    Ok(
+      verify(
+        &password,
+        str::from_utf8(&hash).map_err(|_| Error::from_status(Status::StringExpected))?,
+      )
+      .unwrap_or(false),
     )
-    .map_err(|e| Error::new(Status::GenericFailure, format!("{}", e)))
   }
 }