Skip to content

Commit 7f6a8f4

Browse files
authored
Merge pull request #87 from ym-pett/tidy_selector_imports
chore: fixed compliant selectors import & updated Contributing
2 parents 0d6fdd5 + 2a97390 commit 7f6a8f4

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,12 @@ To run type-checking:
4949
pyright narwhals_daft
5050
```
5151

52+
If your changes add new functionalities, update the tests:
53+
54+
```console
55+
python update_run_tests.py
56+
```
57+
5258
## Updating the Narwhals submodule
5359

5460
Run

narwhals_daft/selectors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from typing import TYPE_CHECKING
44

5-
from narwhals._compliant import CompliantSelector, CompliantSelectorNamespace
5+
from narwhals.compliant import CompliantSelector, CompliantSelectorNamespace
66

77
from narwhals_daft.expr import DaftExpr
88

0 commit comments

Comments
 (0)