replace private `_compliant` imports with public ones

[MarcoGorelli]

we currently import protocols from narwhals._compliant we should replace those private imports with public narwhals.compliant ones, and set narwhals>=2.12 as the minimum version

@ym-pett does it interest you to work on this? no pressure, of course!

[ym-pett]

ohh yes, thanks for pinging me @MarcoGorelli! I'm having a bit of a hectic week though (hence late reply, sorry!). Friday I should be able to start having a look, but I don't want to block others from taking it on, hence not going to assign myself to it yet. If it's taken by Friday, tough luck for me :)

[MarcoGorelli]

😄 sure no worries, i started this in #82 and realised there's a couple more things we need to resolve upstream first

[ym-pett]

I think there are two from narwhals._compliant... imports left at the moment. Do I understand correctly that it doesn't make sense to try to work on them right now because of upstream work needed? (Not sure if I can help with that? )

[MarcoGorelli]

hey! similar to narwhals-dev/narwhals#3344 we should do the same for CompliantSelectorNamespace if you fancy it

[ym-pett]

update: I'm slow on this because my submodule is not updating to the latest commit when I run git submodule update --init --recursive, nothing happens. Currently looking into this!

[MarcoGorelli]

if you do cd narwhals; git log within narwhals-dadtt what does it show? the latest commit there should be 120b6170845a09fe90ce021f061bc8cd3535ad6f

[ym-pett]

hm, so according to this it is up to date, I also get 120b6170845a09fe90ce021f061bc8cd3535ad6f, but I don't see the changes you applied to the compliant.py file in narwhals-dev/narwhals#3344, which I do have in my local stand-alone repository of Narwhals.

I think I need to build on those changes?

[MarcoGorelli]

currently narwhals-daft has the submodule pinned to 120b6170845a09fe90ce021f061bc8cd3535ad6f

to pin it to a more recent commit, you can use https://github.com/narwhals-dev/narwhals-daft/blob/main/utils/submodule_update.sh

i'd just making a PR which just updates the submodule's pinned commit first

[ym-pett]

brilliant will do that, thanks so much for your troubleshooting!

[ym-pett]

I can see that CompliantSelector & CompliantSelectorNamespace are still imported from private _compliant, I'm going to try making a PR in narwhals so that we can import these from compliant, let's see how it goes!