Skip to content

Commit 040d377

Browse files
committed
test: Allow the exception difference *for now*
Aligning this is not important
1 parent aedc330 commit 040d377

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/plan/over_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,13 +145,13 @@ def test_over_raise_len_change(data: Data) -> None:
145145
df.select(nwp.col("b").drop_nulls().over("a"))
146146

147147

148-
# NOTE: Currently raising `InvalidOperationError: `cum_sum()` is not supported in a `group_by` context`
149-
# (main): https://github.com/narwhals-dev/narwhals/blob/ecde261d799a711c2e0a7acf11b108bc45035dc9/narwhals/_arrow/expr.py#L116-L118
150-
# NotImplementedError: Only aggregation or literal operations are supported in grouped `over` context for PyArrow.
151-
@pytest.mark.xfail(reason="Not implemented `cum_sum`", raises=InvalidOperationError)
148+
# NOTE: Slightly different error, but same reason for raising
149+
# (expr-ir): InvalidOperationError: `cum_sum()` is not supported in a `group_by` context
150+
# (main): NotImplementedError: Only aggregation or literal operations are supported in grouped `over` context for PyArrow.
151+
# https://github.com/narwhals-dev/narwhals/blob/ecde261d799a711c2e0a7acf11b108bc45035dc9/narwhals/_arrow/expr.py#L116-L118
152152
def test_unsupported_over(data: Data) -> None:
153153
df = dataframe(data)
154-
with pytest.raises(NotImplementedError):
154+
with pytest.raises(InvalidOperationError):
155155
df.select(nwp.col("a").shift(1).cum_sum().over("b"))
156156

157157

0 commit comments

Comments
 (0)