Skip to content

Commit 12987ee

Browse files
committed
fix: Update SparkLikeExpr.first
1 parent ea30f26 commit 12987ee

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

narwhals/_spark_like/expr.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -610,12 +610,12 @@ def _clip_both(expr: Column, lower_bound: Column, upper_bound: Column) -> Column
610610
)
611611

612612
def first(self) -> Self:
613-
def fn(inputs: SparkWindowInputs) -> Column:
614-
return self._F.first(inputs.expr, ignorenulls=False).over(
615-
self.partition_by(*inputs.partition_by).orderBy(
616-
*self._sort(*inputs.order_by)
617-
)
613+
def fn(df: SparkLikeLazyFrame, inputs: SparkWindowInputs) -> Sequence[Column]:
614+
first = self._F.first
615+
window = self.partition_by(*inputs.partition_by).orderBy(
616+
*self._sort(*inputs.order_by)
618617
)
618+
return [first(expr, ignorenulls=False).over(window) for expr in self(df)]
619619

620620
return self._with_window_function(fn)
621621

0 commit comments

Comments
 (0)