Skip to content

Commit 309f910

Browse files
committed
chore: resolve more conflicts from (#2168)
1 parent 0d57240 commit 309f910

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

narwhals/_compliant/expr.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -748,9 +748,7 @@ def rolling_std(
748748
ddof=ddof,
749749
)
750750

751-
def rolling_sum(
752-
self, window_size: int, *, min_samples: int | None, center: bool
753-
) -> Self:
751+
def rolling_sum(self, window_size: int, *, min_samples: int, center: bool) -> Self:
754752
return self._reuse_series(
755753
"rolling_sum", window_size=window_size, min_samples=min_samples, center=center
756754
)
@@ -805,7 +803,6 @@ class LazyExpr(
805803
sample: not_implemented = not_implemented()
806804
map_batches: not_implemented = not_implemented()
807805
ewm_mean: not_implemented = not_implemented()
808-
rolling_sum: not_implemented = not_implemented()
809806
rolling_mean: not_implemented = not_implemented()
810807
rolling_var: not_implemented = not_implemented()
811808
rolling_std: not_implemented = not_implemented()

narwhals/_duckdb/expr.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -497,3 +497,4 @@ def list(self: Self) -> DuckDBExprListNamespace:
497497
cum_max = not_implemented()
498498
cum_prod = not_implemented()
499499
over = not_implemented()
500+
rolling_sum = not_implemented()

0 commit comments

Comments
 (0)