Skip to content

Commit 372f1eb

Browse files
committed
1 parent 75c5a81 commit 372f1eb

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

narwhals/_pandas_like/selectors.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def _selector(
4747
function_name="selector",
4848
evaluate_output_names=evaluate_output_names,
4949
alias_output_names=None,
50-
implementation=self._implementation, # AttributeError: 'PandasSelector' object has no attribute '_implementation'
50+
implementation=self._implementation,
5151
backend_version=self._backend_version,
5252
version=self._version,
5353
)
@@ -58,19 +58,17 @@ def __init__(self: Self, context: _FullContext, /) -> None:
5858
self._version = context._version
5959

6060

61-
# BUG: `3.8` Protocol?
62-
# https://github.com/narwhals-dev/narwhals/pull/2064#discussion_r1965980715
6361
class PandasSelector( # type: ignore[misc]
6462
CompliantSelector["PandasLikeDataFrame", "PandasLikeSeries"], PandasLikeExpr
6563
):
6664
def _to_expr(self: Self) -> PandasLikeExpr:
6765
return PandasLikeExpr(
68-
self._call, # AttributeError: 'PandasSelector' object has no attribute '_call'
66+
self._call,
6967
depth=self._depth,
7068
function_name=self._function_name,
71-
evaluate_output_names=self._evaluate_output_names, # AttributeError: 'PandasSelector' object has no attribute '_evaluate_output_names'
69+
evaluate_output_names=self._evaluate_output_names,
7270
alias_output_names=self._alias_output_names,
73-
implementation=self._implementation, # AttributeError: 'PandasSelector' object has no attribute '_implementation'
71+
implementation=self._implementation,
7472
backend_version=self._backend_version,
7573
version=self._version,
7674
)

narwhals/_selectors.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from narwhals.utils import is_compliant_dataframe
2323
from narwhals.utils import is_tracks_depth
2424

25-
if not TYPE_CHECKING:
25+
if not TYPE_CHECKING: # pragma: no cover
2626
import sys
2727

2828
if sys.version_info >= (3, 9):
@@ -31,7 +31,7 @@
3131
from typing import Generic
3232

3333
Protocol = Generic
34-
else:
34+
else: # pragma: no cover
3535
from typing import Protocol
3636

3737
if TYPE_CHECKING:

0 commit comments

Comments
 (0)