Merge remote-tracking branch 'upstream/main' into refac-native-module

Author: dangotbanned

.github/workflows/downstream_tests.yml

@@ -187,8 +187,6 @@ jobs:
         run: |
           cd py-shiny
           . .venv/bin/activate
-          # temporary to get CI green
-          uv pip install "chatlas<0.9.0"
           make narwhals-install-shiny
       - name: install-narwhals-dev
         run: |
@@ -242,11 +240,6 @@ jobs:
           cd tea-tasting
           uv pip uninstall narwhals
           uv pip install -e ./..
-      - name: temporary pin duckdb # TODO(FBruzzesi): Unpin duckdb
-        run: |
-          cd tea-tasting
-          uv pip uninstall duckdb
-          uv pip install "duckdb<1.4"
       - name: show-deps
         run: |
           cd tea-tasting
@@ -292,8 +285,6 @@ jobs:
         run: |
           uv pip uninstall narwhals --system
           uv pip install -e . --system
-          # temporary pin to get CI green
-          uv pip install "polars<1.30" --system
       - name: show-deps
         run: uv pip freeze
       - name: Run pytest

.github/workflows/extremes.yml

@@ -29,7 +29,7 @@ jobs:
           cache-suffix: min-versions-${{ matrix.python-version }}
           cache-dependency-glob: "pyproject.toml"
       - name: install-minimum-versions
-        run: uv pip install pipdeptree tox virtualenv setuptools pandas==1.1.3 polars==0.20.4 numpy==1.19.3 pyarrow==13.0.0 "pyarrow-stubs<17" scipy==1.6.0 scikit-learn==1.1.0 duckdb==1.0 tzdata --system
+        run: uv pip install pipdeptree tox virtualenv setuptools pandas==1.1.3 polars==0.20.4 numpy==1.19.3 pyarrow==13.0.0 "pyarrow-stubs<17" scipy==1.6.0 scikit-learn==1.1.0 duckdb==1.1 tzdata --system
       - name: install-reqs
         run: |
           uv pip install -e . --group tests --system
@@ -44,9 +44,9 @@ jobs:
           echo "$DEPS" | grep 'pyarrow==13.0.0'
           echo "$DEPS" | grep 'scipy==1.6.0'
           echo "$DEPS" | grep 'scikit-learn==1.1.0'
-          echo "$DEPS" | grep 'duckdb==1.0'
+          echo "$DEPS" | grep 'duckdb==1.1'
       - name: Run pytest
-        run: pytest tests --cov=narwhals --cov=tests --cov-fail-under=50 --runslow --constructors=pandas,pyarrow,polars[eager],polars[lazy]
+        run: pytest tests --cov=narwhals --cov=tests --cov-fail-under=50 --runslow --constructors=pandas,pyarrow,polars[eager],polars[lazy],duckdb
 
   pretty_old_versions:
     strategy:
@@ -66,7 +66,7 @@ jobs:
           cache-suffix: pretty-old-versions-${{ matrix.python-version }}
           cache-dependency-glob: "pyproject.toml"
       - name: install-pretty-old-versions
-        run: uv pip install pipdeptree tox virtualenv setuptools pandas==1.1.5 polars==0.20.4 numpy==1.19.3 pyarrow==14.0.0 "pyarrow-stubs<17" scipy==1.6.0 scikit-learn==1.1.0 duckdb==1.0 tzdata --system
+        run: uv pip install pipdeptree tox virtualenv setuptools pandas==1.1.5 polars==0.20.4 numpy==1.19.3 pyarrow==14.0.0 "pyarrow-stubs<17" scipy==1.6.0 scikit-learn==1.1.0 duckdb==1.2 tzdata --system
       - name: install-reqs
         run: uv pip install -e . --group tests --system
       - name: show-deps
@@ -82,9 +82,9 @@ jobs:
           echo "$DEPS" | grep 'pyarrow==14.0.0'
           echo "$DEPS" | grep 'scipy==1.6.0'
           echo "$DEPS" | grep 'scikit-learn==1.1.0'
-          echo "$DEPS" | grep 'duckdb==1.0'
+          echo "$DEPS" | grep 'duckdb==1.2'
       - name: Run pytest
-        run: pytest tests --cov=narwhals --cov=tests --cov-fail-under=50 --runslow --constructors=pandas,pyarrow,polars[eager],polars[lazy]
+        run: pytest tests --cov=narwhals --cov=tests --cov-fail-under=50 --runslow --constructors=pandas,pyarrow,polars[eager],polars[lazy],duckdb
 
   not_so_old_versions:
     strategy:
@@ -104,7 +104,7 @@ jobs:
           cache-suffix: not-so-old-versions-${{ matrix.python-version }}
           cache-dependency-glob: "pyproject.toml"
       - name: install-not-so-old-versions
-        run: uv pip install tox virtualenv setuptools pandas==2.0.3 polars==0.20.8 numpy==1.24.4 pyarrow==15.0.0 "pyarrow-stubs<17" scipy==1.8.0 scikit-learn==1.3.0 duckdb==1.0 dask[dataframe]==2024.10 tzdata --system
+        run: uv pip install tox virtualenv setuptools pandas==2.0.3 polars==0.20.8 numpy==1.24.4 pyarrow==15.0.0 "pyarrow-stubs<17" scipy==1.8.0 scikit-learn==1.3.0 duckdb==1.3 dask[dataframe]==2024.10 tzdata --system
       - name: install-reqs
         run: uv pip install -e . --group tests --system
       - name: show-deps
@@ -119,9 +119,9 @@ jobs:
           echo "$DEPS" | grep 'scipy==1.8.0'
           echo "$DEPS" | grep 'scikit-learn==1.3.0'
           echo "$DEPS" | grep 'dask==2024.10'
-          echo "$DEPS" | grep 'duckdb==1.0'
+          echo "$DEPS" | grep 'duckdb==1.3'
       - name: Run pytest
-        run: pytest tests --cov=narwhals --cov=tests --cov-fail-under=50 --runslow --constructors=pandas,pyarrow,polars[eager],polars[lazy],dask
+        run: pytest tests --cov=narwhals --cov=tests --cov-fail-under=50 --runslow --constructors=pandas,pyarrow,polars[eager],polars[lazy],dask,duckdb
 
   nightlies:
     strategy:
@@ -152,10 +152,8 @@ jobs:
           uv pip install pandas --pre --index https://pypi.anaconda.org/scientific-python-nightly-wheels/simple --system -U
       - name: install pyarrow nightly
         run: |
-          # commented out nightly whilst it fails to install
-          uv pip install -U pyarrow --system
-          # uv pip uninstall pyarrow --system
-          # uv pip install pyarrow --pre --index https://pypi.fury.io/arrow-nightlies/ --system -U
+          uv pip uninstall pyarrow --system
+          uv pip install pyarrow --pre --index https://pypi.fury.io/arrow-nightlies/ --system -U
       - name: install numpy nightly
         run: |
           uv pip uninstall numpy --system
@@ -174,9 +172,10 @@ jobs:
         run: |
           DEPS=$(uv pip freeze)
           echo "$DEPS" | grep 'pandas.*dev'
-          # echo "$DEPS" | grep 'pyarrow.*dev'
+          echo "$DEPS" | grep 'pyarrow.*dev'
           echo "$DEPS" | grep 'numpy.*dev'
           echo "$DEPS" | grep 'dask.*@'
+          echo "$DEPS" | grep 'duckdb.*dev'
       - name: Run pytest
         run: |
           pytest tests --cov=narwhals --cov=tests --cov-fail-under=50 --runslow \

.pre-commit-config.yaml

@@ -3,7 +3,7 @@ ci:
 repos:
 - repo: https://github.com/astral-sh/ruff-pre-commit
   # Ruff version.
-  rev: 'v0.13.0'
+  rev: 'v0.14.0'
   hooks:
     # Run the formatter.
     - id: ruff-format
@@ -22,10 +22,12 @@ repos:
       args: [--ignore-words-list=ser]
       exclude: ^docs/api-completeness.md$
 -   repo: https://github.com/pycqa/flake8
-    rev: '7.3.0'  # todo: remove once https://github.com/astral-sh/ruff/issues/458 is addressed
+    rev: '7.3.0'
     hooks:
     -   id: flake8
-        additional_dependencies: [darglint==1.8.1, Flake8-pyproject]
+        # TODO(unassigned): replace with ruff once https://github.com/astral-sh/ruff/issues/458 is addressed.
+        name: darglint
+        alias: darglint
         entry: flake8 --select DAR --ignore DAR101,DAR201,DAR401,DAR402
         exclude: |
             (?x)^(
@@ -39,6 +41,15 @@ repos:
                 # Soft-deprecated, so less crucial to document so carefully
                 narwhals/stable/v1/.*
             )$
+        # Keep in sync with `flake8-typing-imports` so the same venv is reused.
+        additional_dependencies: [darglint==1.8.1, flake8-typing-imports==1.17.0]
+    -   id: flake8
+        # TODO(unassigned): replace with ruff once https://github.com/astral-sh/ruff/issues/2302 is addressed.
+        name: flake8-typing-imports
+        alias: flake8-typing-imports
+        entry: flake8 --select TYP --min-python-version=3.9.0
+        # Keep in sync with `darglint` so the same venv is reused.
+        additional_dependencies: [darglint==1.8.1, flake8-typing-imports==1.17.0]
 - repo: local
   hooks:
     - id: check-api-reference
@@ -47,6 +58,16 @@ repos:
       entry: python -m utils.check_api_reference
       language: python
       additional_dependencies: [polars]
+    - id: sort-api-reference
+      name: sort-api-reference
+      pass_filenames: false
+      entry: python -m utils.sort_api_reference
+      language: python
+    - id: check-slotted-classes
+      name: check-slotted-classes
+      pass_filenames: false
+      entry: python -m utils.check_slotted_classes
+      language: python
     - id: imports-are-banned
       name: import are banned (use `get_pandas` instead of `import pandas`)
       entry: python utils/import_check.py
@@ -62,12 +83,12 @@ repos:
       name: don't import from narwhals.dtypes (use `Version.dtypes` instead)
       entry: |
           (?x)
-            import\ narwhals.dtypes|
-            from\ narwhals\ import\ dtypes|
-            from\ narwhals.dtypes\ import\ [^D_]+|
-            import\ narwhals.stable.v1.dtypes|
-            from\ narwhals.stable\.v.\ import\ dtypes|
-            from\ narwhals.stable\.v.\.dtypes\ import
+            import\ narwhals(\.stable\.v\d)?\.dtypes|
+            from\ narwhals(\.stable\.v\d)?\ import\ dtypes|
+            ^from\ narwhals(\.stable\.v\d)?\.dtypes\ import
+              \ (DType,\ )?
+              ((Datetime|Duration|Enum)(,\ )?)+
+              ((,\ )?DType)?
       language: pygrep
       files: ^narwhals/
       exclude: |
@@ -84,7 +105,7 @@ repos:
       language: pygrep
       files: ^\.github/workflows/
 - repo: https://github.com/adamchainz/blacken-docs
-  rev: "1.19.1"  # replace with latest tag on GitHub
+  rev: "1.20.0"  # replace with latest tag on GitHub
   hooks:
   -   id: blacken-docs
       args: [--skip-errors]

docs/api-reference/dataframe.md

@@ -44,13 +44,13 @@
         - shape
         - sort
         - tail
-        - top_k
         - to_arrow
         - to_dict
         - to_native
         - to_numpy
         - to_pandas
         - to_polars
+        - top_k
         - unique
         - unpivot
         - with_columns

docs/api-reference/expr_dt.md

@@ -18,12 +18,12 @@
         - replace_time_zone
         - second
         - timestamp
+        - to_string
         - total_microseconds
         - total_milliseconds
         - total_minutes
         - total_nanoseconds
         - total_seconds
-        - to_string
         - truncate
         - weekday
         - year

docs/api-reference/expr_str.md

@@ -18,6 +18,7 @@
         - to_date
         - to_datetime
         - to_lowercase
+        - to_titlecase
         - to_uppercase
         - zfill
       show_source: false

docs/api-reference/lazyframe.md

@@ -25,8 +25,8 @@
         - sink_parquet
         - sort
         - tail
-        - top_k
         - to_native
+        - top_k
         - unique
         - unpivot
         - with_columns

docs/api-reference/narwhals.md

@@ -44,9 +44,9 @@ Here are the top-level functions available in Narwhals.
         - read_parquet
         - scan_csv
         - scan_parquet
+        - show_versions
         - sum
         - sum_horizontal
-        - show_versions
         - to_native
         - to_py_scalar
         - when

docs/api-reference/schema.md

@@ -4,13 +4,13 @@
     handler: python
     options:
       members:
-        - names
         - dtypes
         - from_arrow
         - from_native
         - from_pandas_like
         - from_polars
         - len
+        - names
         - to_arrow
         - to_pandas
         - to_polars

docs/api-reference/series.md

@@ -59,8 +59,8 @@
         - median
         - min
         - mode
-        - name
         - n_unique
+        - name
         - null_count
         - pipe
         - quantile
@@ -76,8 +76,8 @@
         - scatter
         - shape
         - shift
-        - sort
         - skew
+        - sort
         - sqrt
         - std
         - sum
@@ -86,10 +86,10 @@
         - to_dummies
         - to_frame
         - to_list
+        - to_native
         - to_numpy
         - to_pandas
         - to_polars
-        - to_native
         - unique
         - value_counts
         - var