Skip to content

Commit 3cc3a1c

Browse files
committed
refactor: Reuse .__array__ for PolarsSeries.to_numpy
- We've already got the compat handled there - `polars` handles the rest in https://github.com/pola-rs/polars/blob/889a2a7a57be5da432b6fa854ab698bbaf1b02ff/py-polars/polars/series/series.py#L1357-L1399
1 parent cf0ae31 commit 3cc3a1c

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

narwhals/_polars/series.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,9 @@ def replace_strict(
174174
raise NotImplementedError(msg)
175175
return self._from_native_series(ser.replace_strict(old, new, return_dtype=dtype))
176176

177+
def to_numpy(self, dtype: Any = None, *, copy: bool | None = None) -> _1DArray:
178+
return self.__array__(dtype, copy=copy)
179+
177180
def __array__(self: Self, dtype: Any, *, copy: bool | None) -> _1DArray:
178181
if self._backend_version < (0, 20, 29):
179182
return self._native_series.__array__(dtype=dtype)
@@ -587,10 +590,6 @@ def hist(
587590
def to_polars(self: Self) -> pl.Series:
588591
return self._native_series
589592

590-
# TODO @dangotbanned: review converting `copy` to a version compat argument
591-
def to_numpy(self, dtype: Any = None, *, copy: bool | None = None) -> _1DArray:
592-
return self.native.to_numpy()
593-
594593
@property
595594
def dt(self: Self) -> PolarsSeriesDateTimeNamespace:
596595
return PolarsSeriesDateTimeNamespace(self)

0 commit comments

Comments
 (0)