Skip to content

Commit 3db4ab4

Browse files
authored
ci: remove sqlglot pin, pin chatlas (#2777)
1 parent ff792be commit 3db4ab4

File tree

1 file changed

+17
-12
lines changed

1 file changed

+17
-12
lines changed

.github/workflows/downstream_tests.yml

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ jobs:
8686
run: |
8787
cd marimo
8888
. .venv/bin/activate
89-
# temporary to get CI green
90-
uv pip install "sqlglot<26.32"
9189
uv pip install -e ".[dev]"
9290
which python
9391
- name: install-narwhals-dev
@@ -178,24 +176,35 @@ jobs:
178176
run: |
179177
git clone https://github.com/posit-dev/py-shiny.git
180178
cd py-shiny
179+
uv venv -p ${{ matrix.python-version }}
181180
git log
182181
- name: install-basics
183-
run: uv pip install --upgrade tox virtualenv setuptools --system
182+
run: |
183+
cd py-shiny
184+
. .venv/bin/activate
185+
uv pip install --upgrade tox virtualenv setuptools
184186
- name: install-shiny-dev
185-
env:
186-
UV_SYSTEM_PYTHON: 1
187187
run: |
188188
cd py-shiny
189+
. .venv/bin/activate
190+
# temporary to get CI green
191+
uv pip install "chatlas<0.9.0"
189192
make narwhals-install-shiny
190193
- name: install-narwhals-dev
191194
run: |
192-
uv pip uninstall narwhals --system
193-
uv pip install -e . --system
195+
cd py-shiny
196+
. .venv/bin/activate
197+
uv pip uninstall narwhals
198+
uv pip install -e ./..
194199
- name: show-deps
195-
run: uv pip freeze
200+
run: |
201+
cd py-shiny
202+
. .venv/bin/activate
203+
uv pip freeze
196204
- name: Run `make narwhals-test-integration`
197205
run: |
198206
cd py-shiny
207+
. .venv/bin/activate
199208
# Isort seems to behave slightly differently in CI
200209
# so we ignore its output
201210
make format -s
@@ -228,8 +237,6 @@ jobs:
228237
run: |
229238
cd tea-tasting
230239
uv sync --group test
231-
# temporary to get CI green
232-
uv pip install "sqlglot<26.32"
233240
- name: install-narwhals-dev
234241
run: |
235242
cd tea-tasting
@@ -450,8 +457,6 @@ jobs:
450457
uv venv -p ${{ matrix.python-version }}
451458
. .venv/bin/activate
452459
uv pip install . --group dev
453-
# temporary to get CI green
454-
uv pip install "sqlglot<26.32"
455460
uv pip install pytest pytest-cov pytest-snapshot pandas polars "ibis-framework[duckdb,mysql,postgres,sqlite]>=9.5.0" chatlas shiny
456461
- name: install-narwhals-dev
457462
run: |

0 commit comments

Comments
 (0)