Skip to content

Commit 45d0231

Browse files
authored
chore: new sqlframe compat (#3488)
* new sqlframe compat * more xfail
1 parent ef7e90b commit 45d0231

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

tests/expr_and_series/skew_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ def test_skew_expr(
5151
# Can not infer schema from empty dataset.
5252
pytest.skip()
5353

54-
if "sqlframe" in str(constructor):
55-
# https://github.com/eakmanrq/sqlframe/issues/522
54+
if "sqlframe" in str(constructor) and int(request.node.callspec.id[-1]) in {2, 4}:
55+
# https://github.com/eakmanrq/sqlframe/issues/610
5656
request.applymarker(pytest.mark.xfail)
5757

5858
result = nw.from_native(constructor({"a": data})).select(nw.col("a").skew())

tests/frame/join_test.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -785,11 +785,7 @@ def test_join_duplicate_column_names(
785785
from pandas.errors import MergeError
786786

787787
exception = MergeError
788-
elif "sqlframe" in str(constructor):
789-
import duckdb
790-
791-
exception = duckdb.BinderException
792-
elif "pyspark" in str(constructor):
788+
elif "pyspark" in str(constructor) and "sqlframe" not in str(constructor):
793789
from pyspark.errors import AnalysisException
794790

795791
exception = AnalysisException

0 commit comments

Comments
 (0)