Skip to content

Commit 4bc483f

Browse files
committed
refactor(DRAFT): big progress on Pandas*
1 parent 388f715 commit 4bc483f

File tree

4 files changed

+67
-499
lines changed

4 files changed

+67
-499
lines changed

narwhals/_expression_parsing.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,13 @@ def func(df: CompliantDataFrame[Any]) -> Sequence[CompliantSeries]:
137137
}
138138

139139
out: list[CompliantSeries] = [
140-
plx._create_series_from_scalar(
140+
plx._create_series_from_scalar( # type: ignore # noqa: PGH003
141141
getattr(series, attr)(**_kwargs),
142142
reference_series=series,
143143
)
144144
if returns_scalar
145145
else getattr(series, attr)(**_kwargs)
146-
for series in expr(df) # type: ignore[arg-type]
146+
for series in expr(df) # type: ignore # noqa: PGH003
147147
]
148148
_, aliases = evaluate_output_names_and_aliases(expr, df, [])
149149
if [s.name for s in out] != list(aliases): # pragma: no cover
@@ -155,8 +155,8 @@ def func(df: CompliantDataFrame[Any]) -> Sequence[CompliantSeries]:
155155
raise AssertionError(msg)
156156
return out
157157

158-
return plx._create_expr_from_callable( # type: ignore[return-value]
159-
func, # type: ignore[arg-type]
158+
return plx._create_expr_from_callable( # type: ignore # noqa: PGH003
159+
func,
160160
depth=expr._depth + 1,
161161
function_name=f"{expr._function_name}->{attr}",
162162
evaluate_output_names=expr._evaluate_output_names,
@@ -183,7 +183,7 @@ def reuse_series_namespace_implementation(
183183
kwargs: keyword arguments to pass to function.
184184
"""
185185
plx = expr.__narwhals_namespace__()
186-
return plx._create_expr_from_callable( # type: ignore[return-value]
186+
return plx._create_expr_from_callable( # type: ignore # noqa: PGH003
187187
lambda df: [
188188
getattr(getattr(series, series_namespace), attr)(**kwargs)
189189
for series in expr(df)

0 commit comments

Comments
 (0)