Skip to content

Commit 66ecf84

Browse files
committed
chore: remove outdated comments
1 parent 7d3addc commit 66ecf84

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

narwhals/_compliant/expr.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,6 @@ def name(self) -> EagerExprNameNamespace[Self]:
792792
return EagerExprNameNamespace(self)
793793

794794

795-
# NOTE: See (https://github.com/narwhals-dev/narwhals/issues/2044#issuecomment-2674262833)
796795
class LazyExpr(
797796
CompliantExpr[CompliantLazyFrameT, NativeExprT_co],
798797
Protocol38[CompliantLazyFrameT, NativeExprT_co],

narwhals/_compliant/series.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ class EagerSeries(CompliantSeries, Protocol[NativeSeriesT_co]):
4848
@property
4949
def native(self) -> NativeSeriesT_co: ...
5050

51-
# NOTE: `ArrowSeries` needs to intercept `value` w/
52-
# if self._backend_version < (13,) and hasattr(value, "as_py"):
53-
# value = value.as_py() # noqa: ERA001
5451
def _from_scalar(self, value: Any) -> Self:
5552
return self._from_iterable([value], name=self.name, context=self)
5653

@@ -63,9 +60,3 @@ def __narwhals_namespace__(self) -> EagerNamespace[Any, Self]: ...
6360

6461
def _to_expr(self) -> EagerExpr[Any, Self]:
6562
return self.__narwhals_namespace__()._expr._from_series(self)
66-
67-
# TODO @dangotbanned: replacing `Namespace._create_compliant_series``
68-
# - All usage within `*Expr.map_batches`
69-
# - `PandasLikeExpr` uses that **once**
70-
# - `ArrowExpr` uses **twice**
71-
# - `PandasLikeDataFrame.with_row_index` uses the wrapped `utils` function once

0 commit comments

Comments
 (0)