Skip to content

Commit 7101b62

Browse files
committed
feat(typing): Add EagerNamespace._dataframe
Now we've got access to both `from_numpy` constructors from `Implementation`!
1 parent aca796a commit 7101b62

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

narwhals/_arrow/namespace.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@
3838

3939

4040
class ArrowNamespace(EagerNamespace[ArrowDataFrame, ArrowSeries, ArrowExpr]):
41+
@property
42+
def _dataframe(self) -> type[ArrowDataFrame]:
43+
return ArrowDataFrame
44+
4145
@property
4246
def _expr(self) -> type[ArrowExpr]:
4347
return ArrowExpr

narwhals/_compliant/namespace.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,8 @@ class EagerNamespace(
109109
DepthTrackingNamespace[EagerDataFrameT, EagerExprT],
110110
Protocol[EagerDataFrameT, EagerSeriesT, EagerExprT],
111111
):
112+
@property
113+
def _dataframe(self) -> type[EagerDataFrameT]: ...
112114
@property
113115
def _series(self) -> type[EagerSeriesT]: ...
114116
def when(

narwhals/_pandas_like/namespace.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@
3434
class PandasLikeNamespace(
3535
EagerNamespace[PandasLikeDataFrame, PandasLikeSeries, PandasLikeExpr]
3636
):
37+
@property
38+
def _dataframe(self) -> type[PandasLikeDataFrame]:
39+
return PandasLikeDataFrame
40+
3741
@property
3842
def _expr(self) -> type[PandasLikeExpr]:
3943
return PandasLikeExpr

0 commit comments

Comments
 (0)