test(typing): fix DataFrame.sort_values overload match (#2109)

dangotbanned · web-flow · commit 746d1962aacd · 2025-02-27T20:30:06.000Z
Resolves #2108 (comment)
diff --git a/tests/hypothesis/join_test.py b/tests/hypothesis/join_test.py
@@ -69,12 +69,12 @@ def test_join(  # pragma: no cover
 
     dframe_pd1 = nw.to_native(dframe_pl).to_pandas()
     dframe_pd1 = dframe_pd1.sort_values(
-        by=dframe_pd1.columns.to_list(), ignore_index=True
+        by=dframe_pd1.columns.to_list(), ignore_index=True, inplace=False
     )
 
     dframe_pd2 = nw.to_native(dframe_pd)
     dframe_pd2 = dframe_pd2.sort_values(
-        by=dframe_pd2.columns.to_list(), ignore_index=True
+        by=dframe_pd2.columns.to_list(), ignore_index=True, inplace=False
     )
 
     assert_frame_equal(dframe_pd1, dframe_pd2)
@@ -114,12 +114,12 @@ def test_cross_join(  # pragma: no cover
 
     dframe_pd1 = nw.to_native(dframe_pl).to_pandas()
     dframe_pd1 = dframe_pd1.sort_values(
-        by=dframe_pd1.columns.to_list(), ignore_index=True
+        by=dframe_pd1.columns.to_list(), ignore_index=True, inplace=False
     )
 
     dframe_pd2 = nw.to_native(dframe_pd)
     dframe_pd2 = dframe_pd2.sort_values(
-        by=dframe_pd2.columns.to_list(), ignore_index=True
+        by=dframe_pd2.columns.to_list(), ignore_index=True, inplace=False
     )
 
     assert_frame_equal(dframe_pd1, dframe_pd2)

Original file line number	Diff line number	Diff line change
`@@ -69,12 +69,12 @@ def test_join( # pragma: no cover`
`69`	`69`
`70`	`70`	`dframe_pd1 = nw.to_native(dframe_pl).to_pandas()`
`71`	`71`	`dframe_pd1 = dframe_pd1.sort_values(`
`72`		`- by=dframe_pd1.columns.to_list(), ignore_index=True`
	`72`	`+ by=dframe_pd1.columns.to_list(), ignore_index=True, inplace=False`
`73`	`73`	`)`
`74`	`74`
`75`	`75`	`dframe_pd2 = nw.to_native(dframe_pd)`
`76`	`76`	`dframe_pd2 = dframe_pd2.sort_values(`
`77`		`- by=dframe_pd2.columns.to_list(), ignore_index=True`
	`77`	`+ by=dframe_pd2.columns.to_list(), ignore_index=True, inplace=False`
`78`	`78`	`)`
`79`	`79`
`80`	`80`	`assert_frame_equal(dframe_pd1, dframe_pd2)`
`@@ -114,12 +114,12 @@ def test_cross_join( # pragma: no cover`
`114`	`114`
`115`	`115`	`dframe_pd1 = nw.to_native(dframe_pl).to_pandas()`
`116`	`116`	`dframe_pd1 = dframe_pd1.sort_values(`
`117`		`- by=dframe_pd1.columns.to_list(), ignore_index=True`
	`117`	`+ by=dframe_pd1.columns.to_list(), ignore_index=True, inplace=False`
`118`	`118`	`)`
`119`	`119`
`120`	`120`	`dframe_pd2 = nw.to_native(dframe_pd)`
`121`	`121`	`dframe_pd2 = dframe_pd2.sort_values(`
`122`		`- by=dframe_pd2.columns.to_list(), ignore_index=True`
	`122`	`+ by=dframe_pd2.columns.to_list(), ignore_index=True, inplace=False`
`123`	`123`	`)`
`124`	`124`
`125`	`125`	`assert_frame_equal(dframe_pd1, dframe_pd2)`