Skip to content

Commit 9f8c7a6

Browse files
committed
feat: Update PandasLikeSeries.from_iterable
1 parent d286331 commit 9f8c7a6

File tree

1 file changed

+20
-8
lines changed

1 file changed

+20
-8
lines changed

narwhals/_pandas_like/series.py

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -173,18 +173,30 @@ def from_iterable(
173173
*,
174174
context: _FullContext,
175175
name: str = "",
176+
dtype: DType | type[DType] | None = None,
176177
index: Any = None,
177178
) -> Self:
178-
return cls(
179-
native_series_from_iterable(
179+
implementation = context._implementation
180+
backend_version = context._backend_version
181+
version = context._version
182+
if dtype:
183+
pd_dtype = narwhals_to_native_dtype(
184+
dtype, None, implementation, backend_version, version
185+
)
186+
ns = implementation.to_native_namespace()
187+
series = ns.Series(data, name=name, dtype=pd_dtype)
188+
else:
189+
series = native_series_from_iterable(
180190
data,
181-
name=name,
191+
name,
182192
index=[] if index is None else index,
183-
implementation=context._implementation,
184-
),
185-
implementation=context._implementation,
186-
backend_version=context._backend_version,
187-
version=context._version,
193+
implementation=implementation,
194+
)
195+
return cls(
196+
series,
197+
implementation=implementation,
198+
backend_version=backend_version,
199+
version=version,
188200
)
189201

190202
@classmethod

0 commit comments

Comments
 (0)