ci: reenable tubular tests (#2467)

* ci: reenable tubular tests

* add --no-sync just in case

* Update .github/workflows/downstream_tests.yml

Author: MarcoGorelli

.github/workflows/downstream_tests.yml

@@ -246,46 +246,45 @@ jobs:
           touch pytest.ini
           uv run --no-sync pytest tests
 
-  # temporarily commented out until they address the `new_series` deprecation
-  # tubular:
-  #   strategy:
-  #     matrix:
-  #       python-version: ["3.12"]
-  #       os: [ubuntu-latest]
+  tubular:
+    strategy:
+      matrix:
+        python-version: ["3.12"]
+        os: [ubuntu-latest]
 
-  #   runs-on: ${{ matrix.os }}
-  #   steps:
-  #     - uses: actions/checkout@v4
-  #     - uses: actions/setup-python@v5
-  #       with:
-  #         python-version: ${{ matrix.python-version }}
-  #     - name: Install uv
-  #       uses: astral-sh/setup-uv@v6
-  #       with:
-  #         enable-cache: "true"
-  #         cache-suffix: ${{ matrix.python-version }}
-  #         cache-dependency-glob: "pyproject.toml"
-  #     - name: clone-tubular
-  #       run: |
-  #         git clone https://github.com/lvgig/tubular --depth=1
-  #         cd tubular
-  #         git log
-  #     - name: install-basics
-  #       run: uv pip install --upgrade tox virtualenv setuptools pytest-env --system
-  #     - name: install-tubular-dev
-  #       run: |
-  #         cd tubular
-  #         uv pip install -e ".[dev]" --system
-  #     - name: install-narwhals-dev
-  #       run: |
-  #         uv pip uninstall narwhals --system
-  #         uv pip install -e . --system
-  #     - name: show-deps
-  #       run: uv pip freeze
-  #     - name: Run pytest
-  #       run: |
-  #         cd tubular
-  #         pytest tests --config-file=pyproject.toml
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Install uv
+        uses: astral-sh/setup-uv@v6
+        with:
+          enable-cache: "true"
+          cache-suffix: ${{ matrix.python-version }}
+          cache-dependency-glob: "pyproject.toml"
+      - name: clone-tubular
+        run: |
+          git clone https://github.com/lvgig/tubular --depth=1
+          cd tubular
+          git log
+      - name: install-basics
+        run: uv pip install --upgrade tox virtualenv setuptools pytest-env --system
+      - name: install-tubular-dev
+        run: |
+          cd tubular
+          uv pip install -e ".[dev]" --system
+      - name: install-narwhals-dev
+        run: |
+          uv pip uninstall narwhals --system
+          uv pip install -e . --system
+      - name: show-deps
+        run: uv pip freeze
+      - name: Run pytest
+        run: |
+          cd tubular
+          pytest tests --config-file=pyproject.toml
 
   plotly:
     strategy:
@@ -496,7 +495,8 @@ jobs:
           touch pytest.ini
           touch tests/__init__.py
           touch tests/utils/__init__.py
-          uv run pytest tests
+          # Keep `--no-sync` in case Narwhals is re-synced with PyPI version
+          uv run --no-sync pytest tests
         timeout-minutes: 15
 
   darts: