Skip to content

Commit ada7648

Browse files
authored
Update marimo downstream CI to use uv instead of hatch (#3487)
* Update marimo downstream CI to use uv instead of hatch Pending on marimo-team/marimo#8510, which replaces hatch with native uv commands in marimo. Uses `uv add ../ --editable` and a new `scripts/test-narwhals.sh` in marimo instead of the old hatch-based test invocation. * Invoke `uv run python`
1 parent e9315d0 commit ada7648

File tree

1 file changed

+9
-26
lines changed

1 file changed

+9
-26
lines changed

.github/workflows/downstream_tests.yml

Lines changed: 9 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -78,35 +78,22 @@ jobs:
7878
cache-dependency-glob: "pyproject.toml"
7979
- name: clone-marimo
8080
run: |
81-
git clone https://github.com/marimo-team/marimo.git --depth=1
81+
# TODO: remove branch pin once https://github.com/marimo-team/marimo/pull/8510 is merged
82+
git clone https://github.com/marimo-team/marimo.git --depth=1 --branch=push-kmswtyynuukw
8283
cd marimo
83-
uv venv -p 3.12
8484
git log
85-
- name: install-basics
86-
run:
87-
uv pip install --upgrade tox virtualenv setuptools hatch
88-
"click!=8.3.0" --system
89-
- name: install-marimo-dev
85+
- name: install-narwhals-dev
9086
run: |
9187
cd marimo
92-
. .venv/bin/activate
88+
uv add ../ --editable
9389
# Temporary pin until it's addressed upstream.
94-
uv pip install "pandas<3"
90+
uv add "pandas<3" --group test-optional
9591
# Temporary pin to get CI green
96-
uv pip install "sqlglot<28.7.0"
97-
uv pip install -e ".[dev]"
98-
which python
99-
- name: install-narwhals-dev
100-
run: |
101-
cd marimo
102-
. .venv/bin/activate
103-
uv pip uninstall narwhals
104-
uv pip install -e ./..
92+
uv add "sqlglot<28.7.0" --group test-optional
10593
- name: show-deps
10694
run: |
10795
cd marimo
108-
. .venv/bin/activate
109-
uv pip freeze
96+
uv tree --group test-optional
11097
- name: Create assets directory, copy over index.html
11198
continue-on-error: true
11299
run: |
@@ -117,12 +104,8 @@ jobs:
117104
if: ${{ matrix.dependencies == 'core,optional' }}
118105
run: |
119106
cd marimo
120-
. .venv/bin/activate
121-
# make sure that we use the .venv when running tests, so that
122-
# the local narwhals install is picked up
123-
sed -i '/^\[tool.hatch.envs.default\]/a path = ".venv"' pyproject.toml
124-
hatch run python -c "import narwhals; print(narwhals.__file__)"
125-
hatch run +py=${{ matrix.python-version }} test-optional:test-narwhals
107+
uv run --python ${{ matrix.python-version }} python -c "import narwhals; print(narwhals.__file__)"
108+
scripts/test-narwhals.sh --python=${{ matrix.python-version }}
126109
timeout-minutes: 15
127110

128111
scikit-lego:

0 commit comments

Comments
 (0)