refactor: Make PandasLikeDataFrame compliant

Author: dangotbanned

narwhals/_pandas_like/dataframe.py

@@ -4,6 +4,7 @@
 from typing import Any
 from typing import Iterator
 from typing import Literal
+from typing import Mapping
 from typing import Sequence
 from typing import cast
 from typing import overload
@@ -356,17 +357,15 @@ def iter_rows(
         *,
         named: bool,
         buffer_size: int,
-    ) -> Iterator[list[tuple[Any, ...]]] | Iterator[list[dict[str, Any]]]:
+    ) -> Iterator[tuple[Any, ...]] | Iterator[dict[str, Any]]:
         # The param ``buffer_size`` is only here for compatibility with the Polars API
         # and has no effect on the output.
         if not named:
             yield from self._native_frame.itertuples(index=False, name=None)
         else:
             col_names = self._native_frame.columns
-            yield from (
-                dict(zip(col_names, row))
-                for row in self._native_frame.itertuples(index=False)
-            )  # type: ignore[misc]
+            for row in self._native_frame.itertuples(index=False):
+                yield dict(zip(col_names, row))
 
     @property
     def schema(self: Self) -> dict[str, DType]:
@@ -418,7 +417,7 @@ def select(self: PandasLikeDataFrame, *exprs: PandasLikeExpr) -> PandasLikeDataF
         return self._from_native_frame(df, validate_column_names=True)
 
     def drop_nulls(
-        self: PandasLikeDataFrame, subset: list[str] | None
+        self: PandasLikeDataFrame, subset: Sequence[str] | None
     ) -> PandasLikeDataFrame:
         if subset is None:
             return self._from_native_frame(
@@ -445,8 +444,8 @@ def with_row_index(self: Self, name: str) -> Self:
             )
         )
 
-    def row(self: Self, row: int) -> tuple[Any, ...]:
-        return tuple(x for x in self._native_frame.iloc[row])
+    def row(self: Self, index: int) -> tuple[Any, ...]:
+        return tuple(x for x in self._native_frame.iloc[index])
 
     def filter(
         self: PandasLikeDataFrame, predicate: PandasLikeExpr | list[bool]
@@ -494,7 +493,7 @@ def with_columns(
         )
         return self._from_native_frame(df, validate_column_names=False)
 
-    def rename(self: Self, mapping: dict[str, str]) -> Self:
+    def rename(self: Self, mapping: Mapping[str, str]) -> Self:
         return self._from_native_frame(
             rename(
                 self._native_frame,
@@ -504,7 +503,7 @@ def rename(self: Self, mapping: dict[str, str]) -> Self:
             )
         )
 
-    def drop(self: Self, columns: list[str], strict: bool) -> Self:  # noqa: FBT001
+    def drop(self: Self, columns: Sequence[str], strict: bool) -> Self:  # noqa: FBT001
         to_drop = parse_columns_to_drop(
             compliant_frame=self, columns=columns, strict=strict
         )
@@ -597,8 +596,8 @@ def join(
         other: Self,
         *,
         how: Literal["left", "inner", "cross", "anti", "semi"],
-        left_on: list[str] | None,
-        right_on: list[str] | None,
+        left_on: Sequence[str] | None,
+        right_on: Sequence[str] | None,
         suffix: str,
     ) -> Self:
         if how == "cross":
@@ -655,7 +654,7 @@ def join(
                 other_native = rename(
                     select_columns_by_name(
                         other._native_frame,
-                        right_on,
+                        list(right_on),
                         self._backend_version,
                         self._implementation,
                     ),
@@ -684,7 +683,7 @@ def join(
                 rename(
                     select_columns_by_name(
                         other._native_frame,
-                        right_on,
+                        list(right_on),
                         self._backend_version,
                         self._implementation,
                     ),
@@ -735,8 +734,8 @@ def join_asof(
         *,
         left_on: str | None,
         right_on: str | None,
-        by_left: list[str] | None,
-        by_right: list[str] | None,
+        by_left: Sequence[str] | None,
+        by_right: Sequence[str] | None,
         strategy: Literal["backward", "forward", "nearest"],
         suffix: str,
     ) -> Self:
@@ -768,7 +767,7 @@ def tail(self: Self, n: int) -> Self:
 
     def unique(
         self: Self,
-        subset: list[str] | None,
+        subset: Sequence[str] | None,
         *,
         keep: Literal["any", "first", "last", "none"],
         maintain_order: bool | None = None,
@@ -1068,8 +1067,8 @@ def sample(
 
     def unpivot(
         self: Self,
-        on: list[str] | None,
-        index: list[str] | None,
+        on: Sequence[str] | None,
+        index: Sequence[str] | None,
         variable_name: str,
         value_name: str,
     ) -> Self:

narwhals/utils.py

@@ -1399,13 +1399,13 @@ def generate_repr(header: str, native_repr: str) -> str:
     )
 
 
-def check_column_exists(columns: list[str], subset: list[str] | None) -> None:
+def check_column_exists(columns: Sequence[str], subset: Sequence[str] | None) -> None:
     if subset is not None and (missing := set(subset).difference(columns)):
         msg = f"Column(s) {sorted(missing)} not found in {columns}"
         raise ColumnNotFoundError(msg)
 
 
-def check_column_names_are_unique(columns: list[str]) -> None:
+def check_column_names_are_unique(columns: Sequence[str]) -> None:
     len_unique_columns = len(set(columns))
     if len(columns) != len_unique_columns:
         from collections import Counter