Skip to content

Commit cae4909

Browse files
committed
revert: Make first, last orderable
1 parent f03ad55 commit cae4909

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

narwhals/_plan/aggregation.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,6 @@ def __repr__(self) -> str:
2929
class Count(Agg): ...
3030

3131

32-
class First(Agg):
33-
"""https://github.com/narwhals-dev/narwhals/issues/2526."""
34-
35-
36-
class Last(Agg):
37-
"""https://github.com/narwhals-dev/narwhals/issues/2526."""
38-
39-
4032
class Max(Agg): ...
4133

4234

@@ -79,6 +71,14 @@ class Var(Agg):
7971
class OrderableAgg(Agg): ...
8072

8173

74+
class First(OrderableAgg):
75+
"""https://github.com/narwhals-dev/narwhals/issues/2526."""
76+
77+
78+
class Last(OrderableAgg):
79+
"""https://github.com/narwhals-dev/narwhals/issues/2526."""
80+
81+
8282
class ArgMin(OrderableAgg): ...
8383

8484

0 commit comments

Comments
 (0)