trying to see an effect of plugin

Author: ym-pett

narwhals/translate.py

@@ -535,6 +535,7 @@ def _from_native_impl(  # noqa: C901, PLR0911, PLR0912, PLR0915
 
     # TODO @mp: this should be connection point to plugin
 
+    # not sure first if statement is needed
     if sys.version_info < (3, 10):
         from importlib_metadata import entry_points
     else:
@@ -544,6 +545,14 @@ def _from_native_impl(  # noqa: C901, PLR0911, PLR0912, PLR0915
 
     print(discovered_plugins)
 
+    """
+    TODO @mp: need logic to go over all the entry points found, and if daft found,
+    (others later), we return the daft dataframe from_native. I think the transformation has
+    to happen inside the daft_plugin, first would just like to see that I can actually read
+    it in
+    
+    """
+
     if not pass_through:
         msg = f"Expected pandas-like dataframe, Polars dataframe, or Polars lazyframe, got: {type(native_object)}"
         raise TypeError(msg)

plugins/daft-plugin/setup.py

@@ -5,7 +5,7 @@
 setuptools.setup(
     name="daft-plugin",
     entry_points={
-        "daft.extension": [
+        "daft-plugin.extension": [
             "X1 = daft-plugin:ExampleOne"
             # "X2 = daft-plugin:ExampleTwo",
         ]

plugins/daft-plugin/src/on_by_default.py

@@ -2,18 +2,13 @@
 
 from __future__ import annotations
 
-from typing import TYPE_CHECKING, Any
-
-if TYPE_CHECKING:
-    from collections.abc import Generator
-
 
 class ExampleOne:
     """First Example Plugin."""
 
-    def __init__(self, tree: Any) -> None:
-        self.tree = tree
+    def __init__(self):
+        pass
 
-    def run(self) -> Generator[Any, Any, None]:
+    def run(self) -> None:
         """Do nothing."""
-        yield from []
+        print('ExampleOne just ran!')