Skip to content

Commit d31d2f4

Browse files
authored
ci: cudf tests fixup (#2795)
1 parent f96130c commit d31d2f4

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

tests/expr_and_series/cast_test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,6 @@ def test_cast_datetime_utc(
245245
"dask" in str(constructor)
246246
# https://github.com/eakmanrq/sqlframe/issues/406
247247
or "sqlframe" in str(constructor)
248-
or "cudf" in str(constructor) # https://github.com/rapidsai/cudf/issues/16973
249248
or ("pyarrow_table" in str(constructor) and is_windows())
250249
):
251250
request.applymarker(pytest.mark.xfail)

tests/expr_and_series/over_test.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,8 @@ def test_len_over_2369(constructor: Constructor, request: pytest.FixtureRequest)
435435

436436

437437
def test_over_quantile(constructor: Constructor, request: pytest.FixtureRequest) -> None:
438-
if "pyarrow_table" in str(constructor) or "pyspark" in str(constructor):
438+
if any(x in str(constructor) for x in ("pyarrow_table", "pyspark", "cudf")):
439+
# cudf: https://github.com/rapidsai/cudf/issues/18159
439440
request.applymarker(pytest.mark.xfail)
440441

441442
data = {"a": [1, 2, 3, 4, 5, 6], "b": ["x", "x", "x", "y", "y", "y"]}
@@ -465,7 +466,8 @@ def test_over_quantile(constructor: Constructor, request: pytest.FixtureRequest)
465466
def test_over_ewm_mean(
466467
constructor_eager: ConstructorEager, request: pytest.FixtureRequest
467468
) -> None:
468-
if "pyarrow_table" in str(constructor_eager) or "modin" in str(constructor_eager):
469+
if any(x in str(constructor_eager) for x in ("pyarrow_table", "modin", "cudf")):
470+
# not implemented
469471
request.applymarker(pytest.mark.xfail)
470472
if "pandas" in str(constructor_eager) and PANDAS_VERSION < (1, 2):
471473
request.applymarker(pytest.mark.xfail(reason="too old, not implemented"))

tests/expr_and_series/rank_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,9 +306,10 @@ def test_rank_with_order_by(
306306
def test_rank_with_order_by_and_partition_by(
307307
constructor: Constructor, request: pytest.FixtureRequest
308308
) -> None:
309-
if any(x in str(constructor) for x in ("dask", "pyarrow_table")):
309+
if any(x in str(constructor) for x in ("dask", "pyarrow_table", "cudf")):
310310
# `rank` is not implemented in Dask
311311
# pyarrow only supports aggregations in `over(partition_by=...)`
312+
# cudf: https://github.com/rapidsai/cudf/issues/18159
312313
request.applymarker(pytest.mark.xfail)
313314
if "pandas_pyarrow" in str(constructor) and PANDAS_VERSION < (2, 1):
314315
pytest.skip(reason="bug in old version")

0 commit comments

Comments
 (0)