Merge remote-tracking branch 'upstream/main' into oh-nodes

Author: dangotbanned

.github/workflows/downstream_tests.yml

@@ -38,8 +38,6 @@ jobs:
         run: |
           cd altair
           uv pip install -e ".[dev, all]" --system
-          # temporary pin to get ci green
-          uv pip install "numpy<2.2" --system
       - name: install-narwhals-dev
         run: |
           uv pip uninstall narwhals --system
@@ -186,10 +184,7 @@ jobs:
           UV_SYSTEM_PYTHON: 1
         run: |
           cd py-shiny
-          # temporary pin to get ci green
           make narwhals-install-shiny
-          uv pip install "pyflakes<3.3.0" "flake8<7.2.0" --system
-          uv pip install "plotly<6.1.0" --system
       - name: install-narwhals-dev
         run: |
           uv pip uninstall narwhals --system
@@ -280,6 +275,8 @@ jobs:
         run: |
           uv pip uninstall narwhals --system
           uv pip install -e . --system
+          # temporary pin to get CI green
+          uv pip install "polars<1.30" --system
       - name: show-deps
         run: uv pip freeze
       - name: Run pytest
@@ -356,8 +353,6 @@ jobs:
       - name: install-deps
         run: |
           cd hierarchicalforecast
-          # temporary pin to get ci green
-          uv pip install "IPython<9" --system
           uv pip install --system ".[dev]"
       - name: install-narwhals-dev
         run: |

.github/workflows/typing.yml

@@ -48,6 +48,5 @@ jobs:
       - name: Run pyright type completeness
         run: |
           source .venv/bin/activate
-          output=$(pyright --verifytypes narwhals --ignoreexternal 2>&1)
-          echo "$output"
-          echo "$output" | grep "Type completeness score: 100%" || exit 1
+          uv pip install -U pyright-cov
+          pyright-cov --verifytypes narwhals --ignoreexternal --fail-under 100

.pre-commit-config.yaml

@@ -1,6 +1,5 @@
 ci:
   autoupdate_schedule: monthly
-  skip: [mypy]
 repos:
 - repo: https://github.com/astral-sh/ruff-pre-commit
   # Ruff version.
@@ -84,13 +83,6 @@ repos:
       entry: pull_request_target
       language: pygrep
       files: ^\.github/workflows/
-    - id: mypy
-      name: mypy
-      entry: make typing
-      language: system
-      types: [python]
-      require_serial: true
-      pass_filenames: false
 - repo: https://github.com/adamchainz/blacken-docs
   rev: "1.19.1"  # replace with latest tag on GitHub
   hooks:

CONTRIBUTING.md

@@ -2,6 +2,23 @@
 
 Thank you for your interest in contributing to Narwhals! Any kind of improvement is welcome!
 
+## **TLDR**
+
+If you've got experience with open source contributions, the following instructions might suffice:
+
+- clone repo: `git clone [email protected]:narwhals-dev/narwhals.git narwhals-dev`
+- `cd narwhals-dev/`
+- `git remote rename origin upstream`
+- `git remote add origin <your fork goes here>`
+- `uv venv -p 3.12`
+- `. .venv/bin/activate`
+- `uv pip install -U -e . --group local-dev`
+- To run tests: `pytest`
+- To run all linting checks: `pre-commit run --all-files`
+- To run static typing checks: `make typing`
+
+For more detailed and beginner-friendly instructions, see below!
+
 ## Local development vs Codespaces
 
 You can contribute to Narwhals in your local development environment, using python3, git and your editor of choice.
@@ -113,6 +130,8 @@ If you want to run PySpark-related tests, you'll need to have Java installed. Re
 
 The pre-commit tool is installed as part of the local-dev dependency group. This will automatically format and lint your code before each commit, and it will block the commit if any issues are found.
 
+Static typing is run separately from `pre-commit`, as it's quite slow. Assuming you followed all the instructions above, you can run it with `make typing`.
+
 #### Option 2: use python3-venv
 
 1. Make sure you have Python 3.8+ installed. If you don't, you can check [install Python](https://realpython.com/installing-python/)

Makefile

@@ -20,7 +20,6 @@ help:  ## Display this help screen
 
 .PHONY: typing
 typing: ## Run typing checks
-    # install duckdb nightly so mypy recognises duckdb.SQLExpression
-	$(VENV_BIN)/uv pip install -U --pre duckdb
 	$(VENV_BIN)/uv pip install -e . --group typing
 	$(VENV_BIN)/mypy
+	$(VENV_BIN)/pyright

narwhals/_duckdb/dataframe.py

@@ -53,7 +53,7 @@
     from narwhals.utils import _FullContext
 
 with contextlib.suppress(ImportError):  # requires duckdb>=1.3.0
-    from duckdb import SQLExpression  # type: ignore[attr-defined, unused-ignore]
+    from duckdb import SQLExpression
 
 
 class DuckDBLazyFrame(

narwhals/_duckdb/expr.py

@@ -56,7 +56,7 @@
     from narwhals.utils import _FullContext
 
 with contextlib.suppress(ImportError):  # requires duckdb>=1.3.0
-    from duckdb import SQLExpression  # type: ignore[attr-defined, unused-ignore]
+    from duckdb import SQLExpression
 
 
 class DuckDBExpr(LazyExpr["DuckDBLazyFrame", "Expression"]):

pyproject.toml

@@ -61,7 +61,8 @@ tests = [
 extra = [  # heavier dependencies we don't necessarily need in every testing job
   "scikit-learn",
 ]
-typing = [
+typing = [  # keep some of these pinned and bump periodically so there's fewer surprises for contributors
+  "duckdb==1.3.0",
   "hypothesis",
   "pytest",
   "pandas-stubs==2.2.3.250308",
@@ -70,7 +71,7 @@ typing = [
   "pyright",
   "pyarrow-stubs==19.2",
   "sqlframe",
-  "polars==1.25.2",
+  "polars==1.30.0",
   "uv",
   "narwhals[ibis]",
 ]